Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that


+
Raghav Gautam 2013-06-26, 13:21
Copy link to this message
-
Re: Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that
Jarek Cecho 2013-06-26, 19:00

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12032/#review22413
-----------------------------------------------------------
Hi Raghav,
thank you very much for taking up this JIRA, appreciated! I'm wondering what is the reasoning for introducing a new query in the Oracle manager to retrive the check column type when the type has been already retrieved and seems to be stored in checkColumnType variable [1]? It seems to me that the real problem here is that the code in the ImportTool is simply overriding this type to Timestamp on [2] before passing it to the datetimeToQueryString [3]. Did you by any chance experiment with removing this line?

It would be also great if you could include a new test for this, so that we can be sure that we won't break this in the future again.

Jarcec

Links:
1: https://github.com/apache/sqoop/blob/trunk/src/java/org/apache/sqoop/tool/ImportTool.java#L70
2: https://github.com/apache/sqoop/blob/trunk/src/java/org/apache/sqoop/tool/ImportTool.java#L286
3: https://github.com/apache/sqoop/blob/trunk/src/java/org/apache/sqoop/manager/OracleManager.java#L578

- Jarek Cecho
On June 26, 2013, 1:21 p.m., Raghav Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12032/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 1:21 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-906
>     https://issues.apache.org/jira/browse/SQOOP-906
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Incremental import using lastmodified mode always assumes column type to be TIMESTAMP which is causing issues with Oracle Connector. This patch fixes that.
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/manager/ConnManager.java c9e05da
>   src/java/org/apache/sqoop/manager/OracleManager.java edc888e
>   src/java/org/apache/sqoop/tool/ImportTool.java cb800b6
>
> Diff: https://reviews.apache.org/r/12032/diff/
>
>
> Testing
> -------
>
> Unit tests & oracle third party tests are passing. Also tested manually.
>
>
> Thanks,
>
> Raghav Gautam
>
>

+
Raghav Gautam 2013-06-30, 14:18
+
Jarek Cecho 2013-07-01, 16:07
+
Raghav Gautam 2013-06-30, 14:18
+
Raghav Gautam 2013-07-01, 20:02
+
Jarek Cecho 2013-07-09, 18:28
+
Raghav Gautam 2013-07-10, 18:33
+
Jarek Cecho 2013-07-11, 22:24
+
Raghav Gautam 2013-07-11, 22:52
+
Raghav Gautam 2013-07-12, 02:13
+
Jarek Cecho 2013-07-15, 17:21
+
Raghav Gautam 2013-07-15, 17:34