|
Vinod Kumar Vavilapalli
2011-09-02, 14:33
Vinod Kumar Vavilapalli
2011-09-02, 14:38
Robert Evans
2011-09-02, 15:10
Giridharan Kesavan
2011-09-02, 17:42
Mahadev Konar
2011-09-02, 17:50
Vinod Kumar Vavilapalli
2011-09-03, 06:16
Jeffrey Naisbitt
2011-09-06, 12:55
Vinod Kumar Vavilapalli
2011-09-06, 13:28
Giridharan Kesavan
2011-09-06, 18:10
Thomas Graves
2011-09-09, 21:24
Giridharan Kesavan
2011-09-09, 22:20
|
-
Jenkins's Links to FindBugs warnings not usefulVinod Kumar Vavilapalli 2011-09-02, 14:33
None of the links to the warnings related to FindBugs by Jenkins on
submitting patch are working. You can see any of the JIRAs being built at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn clean test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate the warnings on my local box. I do see bunch of findBugsXml.xml files which seem to indicating warnings, but they are hardly readable. Does anyone know how to generate html reports locally? Giri? Thanks, +Vinod
-
Re: Jenkins's Links to FindBugs warnings not usefulVinod Kumar Vavilapalli 2011-09-02, 14:38
Oh, I also just found this working link
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/lastSuccessfulBuild/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.htmlon https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/ . Seems that the artifacts are there only for the lastSuccessfulBuild though. +Vinod On Fri, Sep 2, 2011 at 8:03 PM, Vinod Kumar Vavilapalli < [EMAIL PROTECTED]> wrote: > None of the links to the warnings related to FindBugs by Jenkins on > submitting patch are working. You can see any of the JIRAs being built at > https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. > > OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn clean > test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate the > warnings on my local box. I do see bunch of findBugsXml.xml files which seem > to indicating warnings, but they are hardly readable. Does anyone know how > to generate html reports locally? Giri? > > Thanks, > +Vinod >
-
Re: Jenkins's Links to FindBugs warnings not usefulRobert Evans 2011-09-02, 15:10
You can do mvn findbugs:gui and then open up each of the findbugsXml.xml files manually. Or you should be able to run mvn site to generate HTML. You may need to modify the pom.xml file to include findbugs in the report section though.
On 9/2/11 9:38 AM, "Vinod Kumar Vavilapalli" <[EMAIL PROTECTED]> wrote: Oh, I also just found this working link https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/lastSuccessfulBuild/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.htmlon https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/ . Seems that the artifacts are there only for the lastSuccessfulBuild though. +Vinod On Fri, Sep 2, 2011 at 8:03 PM, Vinod Kumar Vavilapalli < [EMAIL PROTECTED]> wrote: > None of the links to the warnings related to FindBugs by Jenkins on > submitting patch are working. You can see any of the JIRAs being built at > https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. > > OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn clean > test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate the > warnings on my local box. I do see bunch of findBugsXml.xml files which seem > to indicating warnings, but they are hardly readable. Does anyone know how > to generate html reports locally? Giri? > > Thanks, > +Vinod >
-
Re: Jenkins's Links to FindBugs warnings not usefulGiridharan Kesavan 2011-09-02, 17:42
artifact archive location for mr per-comitt job on jenkins updated.
-Giri On Fri, Sep 2, 2011 at 7:33 AM, Vinod Kumar Vavilapalli <[EMAIL PROTECTED]> wrote: > None of the links to the warnings related to FindBugs by Jenkins on > submitting patch are working. You can see any of the JIRAs being built at > https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. > > OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn clean > test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate the > warnings on my local box. I do see bunch of findBugsXml.xml files which seem > to indicating warnings, but they are hardly readable. Does anyone know how > to generate html reports locally? Giri? > > Thanks, > +Vinod > -- -Giri
-
Re: Jenkins's Links to FindBugs warnings not usefulMahadev Konar 2011-09-02, 17:50
Thanks Giri!
mahadev On Fri, Sep 2, 2011 at 10:42 AM, Giridharan Kesavan <[EMAIL PROTECTED]> wrote: > artifact archive location for mr per-comitt job on jenkins updated. > -Giri > > On Fri, Sep 2, 2011 at 7:33 AM, Vinod Kumar Vavilapalli > <[EMAIL PROTECTED]> wrote: >> None of the links to the warnings related to FindBugs by Jenkins on >> submitting patch are working. You can see any of the JIRAs being built at >> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. >> >> OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn clean >> test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate the >> warnings on my local box. I do see bunch of findBugsXml.xml files which seem >> to indicating warnings, but they are hardly readable. Does anyone know how >> to generate html reports locally? Giri? >> >> Thanks, >> +Vinod >> > > > > -- > -Giri >
-
Re: Jenkins's Links to FindBugs warnings not usefulVinod Kumar Vavilapalli 2011-09-03, 06:16
It didn't look like it worked.
I just uploaded a patch, still the links turn up nothing: https://issues.apache.org/jira/browse/MAPREDUCE-2716?focusedCommentId=13096590&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13096590 +Vinod On Fri, Sep 2, 2011 at 11:12 PM, Giridharan Kesavan < [EMAIL PROTECTED]> wrote: > artifact archive location for mr per-comitt job on jenkins updated. > -Giri > > On Fri, Sep 2, 2011 at 7:33 AM, Vinod Kumar Vavilapalli > <[EMAIL PROTECTED]> wrote: > > None of the links to the warnings related to FindBugs by Jenkins on > > submitting patch are working. You can see any of the JIRAs being built at > > https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. > > > > OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn > clean > > test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate the > > warnings on my local box. I do see bunch of findBugsXml.xml files which > seem > > to indicating warnings, but they are hardly readable. Does anyone know > how > > to generate html reports locally? Giri? > > > > Thanks, > > +Vinod > > > > > > -- > -Giri >
-
Re: Jenkins's Links to FindBugs warnings not usefulJeffrey Naisbitt 2011-09-06, 12:55
The artifacts are now there in Hudson, but the links seem to be missing the
project in the URL ("hadoop-mapreduce-project") Current links (Broken): https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html Working (notice the extra "hadoop-mapreduce-project"): https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapredu ce-client-shuffle.html On 9/3/11 1:16 AM, "Vinod Kumar Vavilapalli" <[EMAIL PROTECTED]> wrote: > It didn't look like it worked. > > I just uploaded a patch, still the links turn up nothing: > https://issues.apache.org/jira/browse/MAPREDUCE-2716?focusedCommentId=13096590 > &page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment > -13096590 > > +Vinod > > On Fri, Sep 2, 2011 at 11:12 PM, Giridharan Kesavan < > [EMAIL PROTECTED]> wrote: > >> artifact archive location for mr per-comitt job on jenkins updated. >> -Giri >> >> On Fri, Sep 2, 2011 at 7:33 AM, Vinod Kumar Vavilapalli >> <[EMAIL PROTECTED]> wrote: >>> None of the links to the warnings related to FindBugs by Jenkins on >>> submitting patch are working. You can see any of the JIRAs being built at >>> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. >>> >>> OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn >> clean >>> test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate the >>> warnings on my local box. I do see bunch of findBugsXml.xml files which >> seem >>> to indicating warnings, but they are hardly readable. Does anyone know >> how >>> to generate html reports locally? Giri? >>> >>> Thanks, >>> +Vinod >>> >> >> >> >> -- >> -Giri >>
-
Re: Jenkins's Links to FindBugs warnings not usefulVinod Kumar Vavilapalli 2011-09-06, 13:28
Excellent!
Giri, can you please fix this In fact, if you can let me know where to fix this, I am more than willing to fix this myself. For too long we've been pushing Jenkins related work down to you. Thanks, +Vinod On Tue, Sep 6, 2011 at 6:25 PM, Jeffrey Naisbitt <[EMAIL PROTECTED]>wrote: > The artifacts are now there in Hudson, but the links seem to be missing the > project in the URL ("hadoop-mapreduce-project") > > Current links (Broken): > > https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ > patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html > > Working (notice the extra "hadoop-mapreduce-project"): > > https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ > > hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapredu > ce-client-shuffle.html > > > > > > > On 9/3/11 1:16 AM, "Vinod Kumar Vavilapalli" <[EMAIL PROTECTED]> > wrote: > > > It didn't look like it worked. > > > > I just uploaded a patch, still the links turn up nothing: > > > https://issues.apache.org/jira/browse/MAPREDUCE-2716?focusedCommentId=13096590 > > > &page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment > > -13096590 > > > > +Vinod > > > > On Fri, Sep 2, 2011 at 11:12 PM, Giridharan Kesavan < > > [EMAIL PROTECTED]> wrote: > > > >> artifact archive location for mr per-comitt job on jenkins updated. > >> -Giri > >> > >> On Fri, Sep 2, 2011 at 7:33 AM, Vinod Kumar Vavilapalli > >> <[EMAIL PROTECTED]> wrote: > >>> None of the links to the warnings related to FindBugs by Jenkins on > >>> submitting patch are working. You can see any of the JIRAs being built > at > >>> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. > >>> > >>> OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn > >> clean > >>> test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate > the > >>> warnings on my local box. I do see bunch of findBugsXml.xml files which > >> seem > >>> to indicating warnings, but they are hardly readable. Does anyone know > >> how > >>> to generate html reports locally? Giri? > >>> > >>> Thanks, > >>> +Vinod > >>> > >> > >> > >> > >> -- > >> -Giri > >> > >
-
Re: Jenkins's Links to FindBugs warnings not usefulGiridharan Kesavan 2011-09-06, 18:10
this requires a fix to the test-patch script ;
JIRA_COMMENT_FOOTER="Findbugs warnings: $BUILD_URL/artifact/trunk/patchprocess/newPatchFindbugsWarnings${module_suffix}.html test-patch script currently updates findbugs url with trunk/patchprocess instead it has to point to trunk/${projectname}/patchprocess.. this is required for hdfs/common & mapreduce to show the test-patch results. -Giri On Tue, Sep 6, 2011 at 6:28 AM, Vinod Kumar Vavilapalli <[EMAIL PROTECTED]> wrote: > Excellent! > > Giri, can you please fix this > > In fact, if you can let me know where to fix this, I am more than willing > to fix this myself. For too long we've been pushing Jenkins related work > down to you. > > Thanks, > +Vinod > > On Tue, Sep 6, 2011 at 6:25 PM, Jeffrey Naisbitt <[EMAIL PROTECTED]> > wrote: >> >> The artifacts are now there in Hudson, but the links seem to be missing >> the >> project in the URL ("hadoop-mapreduce-project") >> >> Current links (Broken): >> >> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ >> patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html >> >> Working (notice the extra "hadoop-mapreduce-project"): >> >> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ >> >> hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapredu >> ce-client-shuffle.html >> >> >> >> >> >> >> On 9/3/11 1:16 AM, "Vinod Kumar Vavilapalli" <[EMAIL PROTECTED]> >> wrote: >> >> > It didn't look like it worked. >> > >> > I just uploaded a patch, still the links turn up nothing: >> > >> > https://issues.apache.org/jira/browse/MAPREDUCE-2716?focusedCommentId=13096590 >> > >> > &page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment >> > -13096590 >> > >> > +Vinod >> > >> > On Fri, Sep 2, 2011 at 11:12 PM, Giridharan Kesavan < >> > [EMAIL PROTECTED]> wrote: >> > >> >> artifact archive location for mr per-comitt job on jenkins updated. >> >> -Giri >> >> >> >> On Fri, Sep 2, 2011 at 7:33 AM, Vinod Kumar Vavilapalli >> >> <[EMAIL PROTECTED]> wrote: >> >>> None of the links to the warnings related to FindBugs by Jenkins on >> >>> submitting patch are working. You can see any of the JIRAs being built >> >>> at >> >>> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. >> >>> >> >>> OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn >> >> clean >> >>> test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate >> >>> the >> >>> warnings on my local box. I do see bunch of findBugsXml.xml files >> >>> which >> >> seem >> >>> to indicating warnings, but they are hardly readable. Does anyone know >> >> how >> >>> to generate html reports locally? Giri? >> >>> >> >>> Thanks, >> >>> +Vinod >> >>> >> >> >> >> >> >> >> >> -- >> >> -Giri >> >> >> > > -- -Giri
-
Re: Jenkins's Links to FindBugs warnings not usefulThomas Graves 2011-09-09, 21:24
This still seems to be broken. And I think hudson findbugs isn't reporting
properly. Anyone who has hudson access can you take a look at: https://issues.apache.org/jira/browse/MAPREDUCE-2978 Tom On 9/6/11 1:10 PM, "Giridharan Kesavan" <[EMAIL PROTECTED]> wrote: > this requires a fix to the test-patch script ; > JIRA_COMMENT_FOOTER="Findbugs warnings: > $BUILD_URL/artifact/trunk/patchprocess/newPatchFindbugsWarnings${module_suffix > }.html > > test-patch script currently updates findbugs url with > trunk/patchprocess instead it has to point to > trunk/${projectname}/patchprocess.. > > this is required for hdfs/common & mapreduce to show the test-patch results. > > -Giri > > On Tue, Sep 6, 2011 at 6:28 AM, Vinod Kumar Vavilapalli > <[EMAIL PROTECTED]> wrote: >> Excellent! >> >> Giri, can you please fix this >> >> In fact, if you can let me know where to fix this, I am more than willing >> to fix this myself. For too long we've been pushing Jenkins related work >> down to you. >> >> Thanks, >> +Vinod >> >> On Tue, Sep 6, 2011 at 6:25 PM, Jeffrey Naisbitt <[EMAIL PROTECTED]> >> wrote: >>> >>> The artifacts are now there in Hudson, but the links seem to be missing >>> the >>> project in the URL ("hadoop-mapreduce-project") >>> >>> Current links (Broken): >>> >>> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ >>> patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html >>> >>> Working (notice the extra "hadoop-mapreduce-project"): >>> >>> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ >>> >>> hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapredu >>> ce-client-shuffle.html >>> >>> >>> >>> >>> >>> >>> On 9/3/11 1:16 AM, "Vinod Kumar Vavilapalli" <[EMAIL PROTECTED]> >>> wrote: >>> >>>> It didn't look like it worked. >>>> >>>> I just uploaded a patch, still the links turn up nothing: >>>> >>>> https://issues.apache.org/jira/browse/MAPREDUCE-2716?focusedCommentId=13096 >>>> 590 >>>> >>>> &page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comm >>>> ent >>>> -13096590 >>>> >>>> +Vinod >>>> >>>> On Fri, Sep 2, 2011 at 11:12 PM, Giridharan Kesavan < >>>> [EMAIL PROTECTED]> wrote: >>>> >>>>> artifact archive location for mr per-comitt job on jenkins updated. >>>>> -Giri >>>>> >>>>> On Fri, Sep 2, 2011 at 7:33 AM, Vinod Kumar Vavilapalli >>>>> <[EMAIL PROTECTED]> wrote: >>>>>> None of the links to the warnings related to FindBugs by Jenkins on >>>>>> submitting patch are working. You can see any of the JIRAs being built >>>>>> at >>>>>> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. >>>>>> >>>>>> OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn >>>>> clean >>>>>> test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate >>>>>> the >>>>>> warnings on my local box. I do see bunch of findBugsXml.xml files >>>>>> which >>>>> seem >>>>>> to indicating warnings, but they are hardly readable. Does anyone know >>>>> how >>>>>> to generate html reports locally? Giri? >>>>>> >>>>>> Thanks, >>>>>> +Vinod >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> -Giri >>>>> >>> >> >> > >
-
Re: Jenkins's Links to FindBugs warnings not usefulGiridharan Kesavan 2011-09-09, 22:20
like is said before it requires fix to the test-patch.sh script.
"this requires a fix to the test-patch script ; JIRA_COMMENT_FOOTER="Findbugs warnings: $BUILD_URL/artifact/trunk/patchprocess/newPatchFindbugsWarnings${module_suffix}.html test-patch script currently updates findbugs url with trunk/patchprocess instead it has to point to trunk/${projectname}/patchprocess.. this is required for hdfs/common & mapreduce to show the test-patch results. " you are welcome to submit a patch :) On Fri, Sep 9, 2011 at 2:24 PM, Thomas Graves <[EMAIL PROTECTED]> wrote: > This still seems to be broken. And I think hudson findbugs isn't reporting > properly. > > Anyone who has hudson access can you take a look at: > https://issues.apache.org/jira/browse/MAPREDUCE-2978 > > Tom > > On 9/6/11 1:10 PM, "Giridharan Kesavan" <[EMAIL PROTECTED]> wrote: > >> this requires a fix to the test-patch script ; >> JIRA_COMMENT_FOOTER="Findbugs warnings: >> $BUILD_URL/artifact/trunk/patchprocess/newPatchFindbugsWarnings${module_suffix >> }.html >> >> test-patch script currently updates findbugs url with >> trunk/patchprocess instead it has to point to >> trunk/${projectname}/patchprocess.. >> >> this is required for hdfs/common & mapreduce to show the test-patch results. >> >> -Giri >> >> On Tue, Sep 6, 2011 at 6:28 AM, Vinod Kumar Vavilapalli >> <[EMAIL PROTECTED]> wrote: >>> Excellent! >>> >>> Giri, can you please fix this >>> >>> In fact, if you can let me know where to fix this, I am more than willing >>> to fix this myself. For too long we've been pushing Jenkins related work >>> down to you. >>> >>> Thanks, >>> +Vinod >>> >>> On Tue, Sep 6, 2011 at 6:25 PM, Jeffrey Naisbitt <[EMAIL PROTECTED]> >>> wrote: >>>> >>>> The artifacts are now there in Hudson, but the links seem to be missing >>>> the >>>> project in the URL ("hadoop-mapreduce-project") >>>> >>>> Current links (Broken): >>>> >>>> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ >>>> patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html >>>> >>>> Working (notice the extra "hadoop-mapreduce-project"): >>>> >>>> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/595//artifact/trunk/ >>>> >>>> hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapredu >>>> ce-client-shuffle.html >>>> >>>> >>>> >>>> >>>> >>>> >>>> On 9/3/11 1:16 AM, "Vinod Kumar Vavilapalli" <[EMAIL PROTECTED]> >>>> wrote: >>>> >>>>> It didn't look like it worked. >>>>> >>>>> I just uploaded a patch, still the links turn up nothing: >>>>> >>>>> https://issues.apache.org/jira/browse/MAPREDUCE-2716?focusedCommentId=13096 >>>>> 590 >>>>> >>>>> &page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comm >>>>> ent >>>>> -13096590 >>>>> >>>>> +Vinod >>>>> >>>>> On Fri, Sep 2, 2011 at 11:12 PM, Giridharan Kesavan < >>>>> [EMAIL PROTECTED]> wrote: >>>>> >>>>>> artifact archive location for mr per-comitt job on jenkins updated. >>>>>> -Giri >>>>>> >>>>>> On Fri, Sep 2, 2011 at 7:33 AM, Vinod Kumar Vavilapalli >>>>>> <[EMAIL PROTECTED]> wrote: >>>>>>> None of the links to the warnings related to FindBugs by Jenkins on >>>>>>> submitting patch are working. You can see any of the JIRAs being built >>>>>>> at >>>>>>> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/. >>>>>>> >>>>>>> OTOH, I ran "~/Applications/full-packages/apache-maven-3.0.3/bin/mvn >>>>>> clean >>>>>>> test findbugs:findbugs -DskipTests -DHadoopPatchProcess" to generate >>>>>>> the >>>>>>> warnings on my local box. I do see bunch of findBugsXml.xml files >>>>>>> which >>>>>> seem >>>>>>> to indicating warnings, but they are hardly readable. Does anyone know >>>>>> how >>>>>>> to generate html reports locally? Giri? >>>>>>> >>>>>>> Thanks, >>>>>>> +Vinod >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> -Giri >>>>>> >>>> >>> >>> >> >> > > -- -Giri |