Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive >> mail # dev >> Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution


+
Sergey Shelukhin 2013-11-27, 02:21
+
Sergey Shelukhin 2013-11-27, 02:22
+
Eric Hanson 2013-11-27, 19:02
+
Sergey Shelukhin 2013-12-02, 21:18
+
Eric Hanson 2013-12-03, 22:04
+
Eric Hanson 2013-12-02, 22:55
+
Sergey Shelukhin 2013-12-02, 23:33
Copy link to this message
-
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/
-----------------------------------------------------------

(Updated Dec. 3, 2013, 2:06 a.m.)
Review request for hive.
Repository: hive-git
Description
-------

HIVE-5895 vectorization handles division by zero differently from normal execution
Diffs (updated)
-----

  ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
  ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
  ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
  ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 1b79401
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java 9de8461
  ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
  ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938

Diff: https://reviews.apache.org/r/15869/diff/
Testing
-------
Thanks,

Sergey Shelukhin

+
Sergey Shelukhin 2013-12-03, 21:44
+
Sergey Shelukhin 2013-12-03, 23:24
+
Eric Hanson 2013-12-03, 22:03