Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1713 Netcat source to not return "OK"

Rahul Ravindran 2012-11-26, 02:23
Rahul Ravindran 2012-11-26, 02:24
Mike Percy 2012-11-28, 02:54
Rahul Ravindran 2012-11-28, 06:24
Mike Percy 2012-11-28, 08:23
Copy link to this message
Re: Review Request: FLUME-1713 Netcat source to not return "OK"

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 28, 2012, 9:02 p.m.)
Review request for Flume.

Final patch after incorporating Mike's comments

FLUME-1713 Netcat source should allow for *not* returning OK upon receipt of each message; Added a config boolean parameter for this source ackEveryEvent(default value:false). Add parameterized test to existing Netcat unit test
This addresses bug FLUME-1713.
Diffs (updated)

  flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 37c09fe
  flume-ng-core/src/main/java/org/apache/flume/source/NetcatSourceConfigurationConstants.java 1d8b5e4
  flume-ng-doc/sphinx/FlumeUserGuide.rst b4a8868
  flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java 3c17d3d

Diff: https://reviews.apache.org/r/8220/diff/

Unit test added

Rahul Ravindran

Mike Percy 2012-11-29, 07:56