Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1713 Netcat source to not return "OK"


Copy link to this message
-
Review Request: FLUME-1713 Netcat source to not return "OK"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8220/
-----------------------------------------------------------

Review request for Flume.
Description
-------

FLUME-1713 Netcat source should allow for *not* returning OK upon receipt of each message; Added a config boolean parameter for this source ackEveryEvent(default value:false). Add parameterized test to existing Netcat unit test
This addresses bug FLUME-1713.
    https://issues.apache.org/jira/browse/FLUME-1713
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 37c09fe
  flume-ng-core/src/main/java/org/apache/flume/source/NetcatSourceConfigurationConstants.java 1d8b5e4
  flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java 3c17d3d

Diff: https://reviews.apache.org/r/8220/diff/
Testing
-------

Unit test added
Thanks,

Rahul Ravindran

+
Rahul Ravindran 2012-11-26, 02:24
+
Mike Percy 2012-11-28, 02:54
+
Rahul Ravindran 2012-11-28, 06:24
+
Mike Percy 2012-11-28, 08:23
+
Rahul Ravindran 2012-11-28, 21:02
+
Mike Percy 2012-11-29, 07:56