-Re: Review Request 12244: Patch to add SSL support to HTTP Source, Flume-2109
Thanks Hari !
I thought about it, but since I was not sure about it, so enabled both
connectors. Shall upload the patch with review comments again, in couple of
On Wed, Jul 10, 2013 at 6:58 AM, Hari Shreedharan <[EMAIL PROTECTED]
> This is an automatically generated e-mail. To reply, visit:
> This looks pretty good. Right now it looks like both SSL and non-SSL connectors will be enabled if SSL is enabled. I don't think we should have both enabled - if SSL is enabled only secure connections should be possible. That is how even the Avro Source works right now.
> - Hari Shreedharan
> On July 4th, 2013, 6:08 a.m. UTC, Ashish Paliwal wrote:
> Review request for Flume.
> By Ashish Paliwal.
> *Updated July 4, 2013, 6:08 a.m.*
> *Bugs: * FLUME-2109 <https://issues.apache.org/jira/browse/FLUME-2109>
> *Repository: * flume-git
> Patch for Flume-2109, to add HTTPS support to HTTP Source
> Unit Test added to verify SSL messages being sent to the Source.
> - flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java
> - flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java
> - flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java
> - flume-ng-doc/sphinx/FlumeUserGuide.rst (63cad21)
> View Diff <https://reviews.apache.org/r/12244/diff/>
My Photo Galleries: http://www.pbase.com/ashishpaliwal