Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request: HIVE-4718 Incorrect handling of string keys and null values in VectorHashKey


Copy link to this message
-
Review Request: HIVE-4718 Incorrect handling of string keys and null values in VectorHashKey

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11963/
-----------------------------------------------------------

Review request for hive and Jitendra Pandey.
Description
-------

A more thorough fix, with unit tests included.
This addresses bug HIVE-4718.
    https://issues.apache.org/jira/browse/HIVE-4718
Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java 8d1f0e1
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapperBatch.java 06a91d0
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java ba6e8c4
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/util/FakeVectorRowBatchFromObjectIterables.java 35389b1

Diff: https://reviews.apache.org/r/11963/diff/
Testing
-------

new unit tests added
Thanks,

Remus Rusanu