Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Re: Review Request 15245: ACCUMULO-1009 - add use of SSL for thrift comms (was https://reviews.apache.org/r/14972/)


Copy link to this message
-
Re: Review Request 15245: ACCUMULO-1009 - add use of SSL for thrift comms (was https://reviews.apache.org/r/14972/)
keith@... 2013-11-07, 17:35

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15245/#review28381
-----------------------------------------------------------

core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java
<https://reviews.apache.org/r/15245/#comment55201>

    In the old review there was discussion about passing in a generic commons configuration object and having javadoc point to ClientConfiguration.  

core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java
<https://reviews.apache.org/r/15245/#comment55199>

    This should be deprecated since a new client side configuration was introduced.  Having the server side configuration here is just confusing.   Deprecating it will make it clear that its not intended to be used.

core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java
<https://reviews.apache.org/r/15245/#comment55200>

    Also need to deprecate.

core/src/main/java/org/apache/accumulo/core/security/ssl/SslConnectionParams.java
<https://reviews.apache.org/r/15245/#comment55202>

    Is this internal code?  Should it be in the public API?  If not it should go in a different package, like core.impl or something that indicates its for internal use only.  There are already classes in core.security that are part of the API.
- kturner
On Nov. 6, 2013, 2:57 p.m., Michael Berman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15245/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 2:57 p.m.)
>
>
> Review request for accumulo, Sean Busbey, Christopher Tubbs, John Vines, and kturner.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> (was https://reviews.apache.org/r/14972/ ; created new review created so I get responses instead of Vines)
>
> Rebased on 1.6.0-SNAPSHOT's current HEAD (which is pretty close to master), and feedback from the last review integrated.
>
> Still need to clean up all the references to newly deprecated ZKInstance constructors and Input/OutputFormat config setters, but wanted to get this up for feedback sooner.
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java 9247d56
>   core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java a85b72e
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java bb5987d
>   core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java 32c80f9
>   core/src/main/java/org/apache/accumulo/core/client/impl/ServerClient.java 218bd36
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java 0376304
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java 0dd86bf
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportKey.java f07139d
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportPool.java e7dabb5
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java 856936e
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java cccd7b8
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloMultiTableInputFormat.java 61838db
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java 908b8b3
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormat.java fe5003b
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java 626a785
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java 9ecae53
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 727bfec
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormat.java 992990d