Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Bigtop, mail # dev - Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic init script template adapted from Hadoop's services)


Copy link to this message
-
Re: Review Request: BIGTOP-805: Upgrading to Sqoop 2 (and using a generic init script template adapted from Hadoop's services)
Sean Mackrory 2013-02-04, 19:26


> On Feb. 2, 2013, 1:27 a.m., Jarek Cecho wrote:
> > bigtop-packages/src/common/sqoop/setenv.sh, line 17
> > <https://reviews.apache.org/r/9264/diff/1/?file=254771#file254771line17>
> >
> >     I'm wondering where is this script being executed? I did not found it's reference anywhere other than installation files.

Tomcat checks for a file with this name and executes it if it exists on start up.
> On Feb. 2, 2013, 1:27 a.m., Jarek Cecho wrote:
> > bigtop-packages/src/common/sqoop/do-component-build, line 19
> > <https://reviews.apache.org/r/9264/diff/1/?file=254769#file254769line19>
> >
> >     Calling the "site" target should not be necessary here. Also we might want to explicitly add -Dhadoop.profile=200 so that it will build against Hadoop 2.0.0. I know that it's current default, but that might change and cause unnecessary issues.

Will incorporate both suggestions in the next patch. I believe something is messed up with sphinx in my environment because it's working fine without site on a couple of VMs.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9264/#review16034
-----------------------------------------------------------
On Feb. 1, 2013, 9:53 p.m., Sean Mackrory wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9264/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 9:53 p.m.)
>
>
> Review request for bigtop and Jarek Cecho.
>
>
> Description
> -------
>
> This patch upgrades Sqoop from the 1.x series to the 2.x series (that is currently actually at 1.99.1). The new architecture consists of a lightweight client and a centralized server. I've also adapted the init script template used by the Hadoop services and used it for sqoop-server. It's available for all subsequent components that want to make use of it - should make it easier to solve common bugs and be consistent.
>
>
> This addresses bug BIGTOP-805.
>     https://issues.apache.org/jira/browse/BIGTOP-805
>
>
> Diffs
> -----
>
>   bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION
>   bigtop-packages/src/common/sqoop/catalina.properties.mr1 PRE-CREATION
>   bigtop-packages/src/common/sqoop/do-component-build 42a2442
>   bigtop-packages/src/common/sqoop/install_sqoop.sh e752c4e
>   bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION
>   bigtop-packages/src/common/sqoop/sqoop-env.sh PRE-CREATION
>   bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3
>   bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef
>   bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION
>   bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION
>   bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION
>   bigtop-packages/src/deb/sqoop/compat 7f8f011
>   bigtop-packages/src/deb/sqoop/control dcc6106
>   bigtop-packages/src/deb/sqoop/copyright ec176a9
>   bigtop-packages/src/deb/sqoop/rules 7992dcd
>   bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION
>   bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635
>   bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26
>   bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION
>   bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION
>   bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION
>   bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e
>   bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION
>   bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5
>   bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326
>   bigtop-packages/src/templates/init.d.tmpl PRE-CREATION
>   bigtop.mk 96f2257
>   package.mk 8e45771
>
> Diff: https://reviews.apache.org/r/9264/diff/
>
>
> Testing
> -------
>
> I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu Lucid.