Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Zookeeper >> mail # dev >> ZK-1246 blocker for 3.4 release?


Copy link to this message
-
Re: ZK-1246 blocker for 3.4 release?
Thanks a lot Camille.

mahadev
On Tue, Oct 25, 2011 at 1:42 PM, Camille Fournier <[EMAIL PROTECTED]> wrote:
> I have a fix and a test that shows the error. Will get a patch together soon.
>
> On Tue, Oct 25, 2011 at 3:20 PM, Camille Fournier <[EMAIL PROTECTED]> wrote:
>> I'm happy to take a look at this and post progress. I'm in a hospital
>> waiting for a baby to be born so I will be on and off but I'll post
>> what I get through.
>>
>> C
>>
>> On Tue, Oct 25, 2011 at 1:16 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>>> I think mockito should be useful here. Our code needs to be a little
>>> cleaner to be able to test these with "real" unit tests :).
>>>
>>> thanks
>>> mahadev
>>>
>>> On Tue, Oct 25, 2011 at 10:14 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>> Do we have a test that exercises this code path? Any commit we should
>>>> really include something that verifies the change.
>>>>
>>>> On Tue, Oct 25, 2011 at 10:12 AM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>>>>> Thomas,
>>>>> Any chance, you could make the change just on 3.4 branch without the
>>>>> Enum changes and others?
>>>>>
>>>>> thanks
>>>>> mahadev
>>>>>
>>>>> On Tue, Oct 25, 2011 at 10:09 AM, Thomas Koch <[EMAIL PROTECTED]> wrote:
>>>>>> Ted Dunning:
>>>>>>> I would love to.  My travel schedule just now is pretty heinous so I don't
>>>>>>> know when I will get to it.
>>>>>> This is how I (hopefully) fixed this:
>>>>>> https://github.com/thkoch2001/zookeeper/blob/proposed_patches/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java#L525
>>>>>>
>>>>>> However I've several major changes made before that:
>>>>>> - enum for OpCode
>>>>>> - a class Request.Meta that holds all request meta-data: zxid, cxid, time,
>>>>>> type, owner, authinfo
>>>>>> - request lost all setXYZ methods except setException to move towards an
>>>>>> immutable request
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Thomas Koch, http://www.koch.ro
>>>>>>
>>>>>
>>>>
>>>
>>
>