Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Review Request 14880: ACCUMULO-1785 Alter config.sh to optionally just verify environment instead of making changes


Copy link to this message
-
Re: Review Request 14880: ACCUMULO-1785 Alter config.sh to optionally just verify environment instead of making changes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14880/#review27417
-----------------------------------------------------------

bin/config.sh
<https://reviews.apache.org/r/14880/#comment53275>

    This should be a separate commit

bin/config.sh
<https://reviews.apache.org/r/14880/#comment53277>

    This looks like it will spit stuff to STDERR if masters file isn't there and ACCUMULO_VERIFY_ONLY is set, and won't set GC.

bin/config.sh
<https://reviews.apache.org/r/14880/#comment53276>

    Can this still happen if ACCUMULO_VERIFY_ONLY is set and no masters file exists?

bin/config.sh
<https://reviews.apache.org/r/14880/#comment53278>

    Same issue with GC not being set applies to MONITOR not being set and can't be set from master if ACCUMULO_VERIFY_ONLY is set and no masters file.
- Christopher Tubbs
On Oct. 23, 2013, 3:08 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14880/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 3:08 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1785
>     https://issues.apache.org/jira/browse/ACCUMULO-1785
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Updates config.sh to skip automagic standalone mode and avoid writing to the local filesystem given an optional environment variable. Adds additional error handling since this changes the invariant that a conf/masters file will exist.
>
>
> Diffs
> -----
>
>   bin/config.sh 9277406
>
> Diff: https://reviews.apache.org/r/14880/diff/
>
>
> Testing
> -------
>
> functional tests
> starting w/o env variable set and no master/slaves correctly started in standalone mode.
> starting w/env variable and no required variables and no master/slaves correctly complained and failed.
> starting w/env variable and required variables and no master/slaves correctly init w/o writing crap, correctly failed to use start-all
> starting with a normal cluster config
>
>
> Thanks,
>
> Sean Busbey
>
>