Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-433: Tests are failing on current 0.23 version


Copy link to this message
-
Re: Review Request: SQOOP-433: Tests are failing on current 0.23 version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3736/#review4783
-----------------------------------------------------------
Thanks for the patch, Jarcec.  Just one nit below.
/build.xml
<https://reviews.apache.org/r/3736/#comment10515>

    It would be nice if you could make the comment a bit clearer, something like, "Set to an empty string below due to MAPREDUCE-3736"
- Bilung
On 2012-02-02 17:44:27, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3736/
> -----------------------------------------------------------
>
> (Updated 2012-02-02 17:44:27)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> I've tried most simple change to get it working, however I'm not sure how dirty this solution is or whether it's even acceptable.
>
>
> This addresses bug SQOOP-433.
>     https://issues.apache.org/jira/browse/SQOOP-433
>
>
> Diffs
> -----
>
>   /build.xml 1239338
>
> Diff: https://reviews.apache.org/r/3736/diff
>
>
> Testing
> -------
>
> All supported versions went fine:
>
> ant -Dhadoopversion=20 test
> ant -Dhadoopversion=23 test
> ant -Dhadoopversion=100 test
>
>
> Thanks,
>
> Jarek
>
>