Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 14113: support standard UDFs and generic UDFs in vectorized mode with an adaptor


Copy link to this message
-
Re: Review Request 14113: support standard UDFs and generic UDFs in vectorized mode with an adaptor
Brock Noland 2013-09-13, 06:00

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14113/#review26071
-----------------------------------------------------------
Hey,

First off let me say you've don't a massive job in the vectorization branch! Nice work! I obviously don't have a enough context to do a real review. However, I just noticed you guys wanted to merge this branch soon so I took a peak at this issue. There is a large amount of trailing whitespace in this patch. Can you remove that? It shows up in red on RB.
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
<https://reviews.apache.org/r/14113/#comment50900>

    Does something require ArrayList to be on the LHS?
- Brock Noland
On Sept. 12, 2013, 11:57 p.m., Eric Hanson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14113/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 11:57 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-4961
>     https://issues.apache.org/jira/browse/HIVE-4961
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added support standard UDFs and generic UDFs in vectorized mode with an adaptor. Includes unit tests.
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 3d8ade6
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFAdaptor.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFArgDesc.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 5b467bb
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 048824a
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 52fe47b
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/GenericUDFIsNull.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/LongUDF.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestUDF.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorUDFAdaptor.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14113/diff/
>
>
> Testing
> -------
>
> Also did extensive ad-hoc end-to end tests with a variety of UDFs.
>
>
> Thanks,
>
> Eric Hanson
>
>