Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 12374: Unify logging across sqoop2 codebase


Copy link to this message
-
Re: Review Request 12374: Unify logging across sqoop2 codebase

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12374/#review22957
-----------------------------------------------------------

Ship it!
Hi Raghav,
thank you very much for taking up this ticket and unifying the logger usage! I do have just one very minor nit. Please fix it and upload the patch to the JIRA!
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
<https://reviews.apache.org/r/12374/#comment46744>

    Nit: Would you mind adding keyword static here?
Jarcec

- Jarek Cecho
On July 9, 2013, 9:09 p.m., Raghav Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12374/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 9:09 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-672
>     https://issues.apache.org/jira/browse/SQOOP-672
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> This patch unifies logging across sqoop2 codebase and few minor problems related to it.
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java 60a69e0
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java 58d6c10
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportExtractor.java 9281bb4
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ProgressRunnable.java 7e87250
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 4493a45
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java 813f370
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 0721b7e
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 7715d5f
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 54604a7
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java d47f861
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java e4ad6ba
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 7842e32
>   server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 48fe0ff
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 18b9997
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 1f7a208
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java fbf46e9
>
> Diff: https://reviews.apache.org/r/12374/diff/
>
>
> Testing
> -------
>
> unit tests are good
>
>
> Thanks,
>
> Raghav Gautam
>
>