Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Re: Review Request 8559: Add Accumulo support to Sqoop


Copy link to this message
-
Re: Review Request 8559: Add Accumulo support to Sqoop


> On Oct. 24, 2013, 5:09 p.m., Sean Busbey wrote:
> > src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java, lines 42-58
> > <https://reviews.apache.org/r/8559/diff/5/?file=370079#file370079line42>
> >
> >     Could you rewrite this to use the @Test(expects=IOException.class) form?
>
> Philip Grim wrote:
>     Apparently, I can't.
>    
>     My test cases are using the Sqoop-provided base test case, which extends JUnit test case.  This appears to cause JUnit to only use JUnit 3 semantics when interpreting the @Test annotations, so the expects clause doesn't work.
>
> Philip Grim wrote:
>     My suggestion is to drop this for now, and talk about refactoring the test cases in a more JUnit 4 compliant way in another issue.  I'm open to alternate suggestions if you know a solution I'm missing.

Sounds good to me.
> On Oct. 24, 2013, 5:09 p.m., Sean Busbey wrote:
> > src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java, lines 105-122
> > <https://reviews.apache.org/r/8559/diff/5/?file=370079#file370079line105>
> >
> >     Could you rewrite this to use the @Test(expects=IOException.class) form?
>
> Philip Grim wrote:
>     Same as above.

Sounds good to me.
> On Oct. 24, 2013, 5:09 p.m., Sean Busbey wrote:
> > src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java, lines 50-68
> > <https://reviews.apache.org/r/8559/diff/5/?file=370080#file370080line50>
> >
> >     Could you rewrite this to use the @Test(expects=IOException.class) form?
>
> Philip Grim wrote:
>     Same as above.

Sounds good to me.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8559/#review27458
-----------------------------------------------------------
On Oct. 29, 2013, 9:22 p.m., Philip Grim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8559/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 9:22 p.m.)
>
>
> Review request for accumulo, Sqoop and Jarek Cecho.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds the ability to import to an Accumulo table in much the same manner as the current HBase import capability.  Reported in JIRA as ACCUMULO-141 and SQOOP-767.
>
>
> Diffs
> -----
>
>   ivy.xml c5130ae
>   src/docs/user/accumulo-args.txt PRE-CREATION
>   src/docs/user/accumulo.txt PRE-CREATION
>   src/java/org/apache/sqoop/SqoopOptions.java 13637b5
>   src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java PRE-CREATION
>   src/java/org/apache/sqoop/accumulo/AccumuloUtil.java PRE-CREATION
>   src/java/org/apache/sqoop/accumulo/MutationTransformer.java PRE-CREATION
>   src/java/org/apache/sqoop/accumulo/ToStringMutationTransformer.java PRE-CREATION
>   src/java/org/apache/sqoop/manager/SqlManager.java 1ffa40f
>   src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java PRE-CREATION
>   src/java/org/apache/sqoop/mapreduce/AccumuloImportMapper.java PRE-CREATION
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9230f82
>   src/java/org/apache/sqoop/tool/ImportTool.java fbbde1d
>   src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java PRE-CREATION
>   src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java PRE-CREATION
>   src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java PRE-CREATION
>   src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8559/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Philip Grim
>
>