Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 12216: SQOOP-1089 Sqoop2: Accept Language header default


Copy link to this message
-
Re: Review Request 12216: SQOOP-1089 Sqoop2: Accept Language header default
Hari Shreedharan 2013-07-02, 00:27

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12216/#review22637
-----------------------------------------------------------

Ship it!
+1. This looks good. I will run tests and commit later today unless there is any objection.

- Hari Shreedharan
On July 2, 2013, 12:23 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12216/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 12:23 a.m.)
>
>
> Review request for Sqoop, Hari Shreedharan and Jarek Cecho.
>
>
> Bugs: SQOOP-1089
>     https://issues.apache.org/jira/browse/SQOOP-1089
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 1db0513e9ddd4c1f7d3b389f0d4932b2bd96e3ee
> Author: Abraham Elmahrek <[EMAIL PROTECTED]>
> Date:   Mon Jul 1 17:18:29 2013 -0700
>
>     SQOOP-1089 Sqoop2: Accept Language header default
>    
>     Using Locale.getDefault().
>
> :100644 100644 4ed7f58... f65017a... M server/src/main/java/org/apache/sqoop/server/RequestContext.java
>
>
> Diffs
> -----
>
>   server/src/main/java/org/apache/sqoop/server/RequestContext.java 4ed7f58
>
> Diff: https://reviews.apache.org/r/12216/diff/
>
>
> Testing
> -------
>
> mvn test
> curl http://solaris:12000/sqoop/v1/connector/all no longer throws and exception.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>