Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 13181: SQOOP-773 Sqoop2: Batch execution support for client commands


Copy link to this message
-
Re: Review Request 13181: SQOOP-773 Sqoop2: Batch execution support for client commands


> On Oct. 11, 2013, 8:02 p.m., Jarek Cecho wrote:
> > Hi Abe,
> > thank you very much for working on the patch, appreciated! I've tested it in my environment and I do have couple of notes:
> >
> > I think that we need to ensure that one failed command will end entire script execution. I'm thinking about use case that would do the following:
> >
> > 1) create connection
> > 2) create job for -^
> > 3) run the job -^
> >
> > In such situation we need to ensure that we are not creating job for non-existing connection or running non-existing job.
>
> Abraham Elmahrek wrote:
>     Thanks for the review Jarcec. Would it be appropriate to have executeFunction and its parent callers return a boolean value rather than an Object value? I think an Object value would be useful, but perhaps a more abstracted Object value that we could handle in a follow up jira. i.e. A class that contains a Status and a return object?
>
> Jarek Cecho wrote:
>     The reason why the executeFunction() methods are returning Object instead of boolean is that it's expected by Groovy shell. Having said that I would prefer to return what is expected from us, rather then limit it to a boolean value only.
>
> Abraham Elmahrek wrote:
>     Jarcec, I've created SQOOP-1217 to follow up. For now we can return an Object, but since the result will normally be null, the script will stop executing after one command. To improve this, in this review, I'll return a non-null object to indicate execution should progress and a null value to indicate execution should halt. Then, in SQOOP-1217, we can follow through with a different kind of object that would encapsulate information on whether the batch script should continue, or stop, and the result object itself.

Sounds good to me, thank you for following on this!
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13181/#review26935
-----------------------------------------------------------
On Oct. 14, 2013, 7:05 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13181/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2013, 7:05 p.m.)
>
>
> Review request for Sqoop, Hari Shreedharan and Jarek Cecho.
>
>
> Bugs: SQOOP-773
>     https://issues.apache.org/jira/browse/SQOOP-773
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 080ced16578c1d95015ce3e99b4335beb465861a
> Author: Abraham Elmahrek <[EMAIL PROTECTED]>
> Date:   Tue Aug 13 14:14:06 2013 -0700
>
>     SQOOP-773 Sqoop2: Batch execution support for client commands
>    
>     Separated options into two groups: fixed and dynamic options.
>     Fixed options (IE: connector ID) come first and are used to select
>     what options should be used in dynamic options. Dynamic options
>     are automatically created based on forms selected from fixed options.
>     The keys for these options take on the form "<prefix>-<form name>-<input-name>".
>
> :100644 100644 980a908... a7e7e7d... M  shell/src/main/java/org/apache/sqoop/shell/CloneCommand.java
> :100644 100644 856abaa... 2c2869c... M  shell/src/main/java/org/apache/sqoop/shell/CloneConnectionFunction.java
> :100644 100644 3e23025... dd2eb2b... M  shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java
> :100644 100644 e62ce08... 9ad007b... M  shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
> :100644 100644 5fbf0a3... 973fd53... M  shell/src/main/java/org/apache/sqoop/shell/CreateConnectionFunction.java
> :100644 100644 6e4f04b... f0d4a6c... M  shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java
> :100644 100644 c123732... d79516d... M  shell/src/main/java/org/apache/sqoop/shell/DeleteConnectionFunction.java
> :100644 100644 d4095b7... df9a2cc... M  shell/src/main/java/org/apache/sqoop/shell/DeleteJobFunction.java