Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill, mail # dev - Review Request 14027: Adding Limit operator end to end


+
Timothy Chen 2013-09-08, 17:37
+
Timothy Chen 2013-09-10, 08:29
+
Jacques Nadeau 2013-09-18, 18:39
+
Jacques Nadeau 2013-09-19, 01:34
+
Timothy Chen 2013-09-19, 01:14
+
Jacques Nadeau 2013-09-19, 01:04
+
Julian Hyde 2013-09-18, 19:10
+
Timothy Chen 2013-09-21, 00:57
+
Timothy Chen 2013-09-21, 01:13
+
Timothy Chen 2013-09-21, 05:56
+
Julian Hyde 2013-09-27, 16:57
+
Timothy Chen 2013-09-28, 08:01
+
Julian Hyde 2013-09-29, 22:01
+
Timothy Chen 2013-09-29, 22:22
+
Timothy Chen 2013-09-29, 22:23
+
Timothy Chen 2013-10-06, 20:09
+
Jacques Nadeau 2013-10-09, 18:00
Copy link to this message
-
Re: Review Request 14027: Adding Limit operator end to end
Timothy Chen 2013-10-09, 18:10
Amazing!

Can you maybe explain a bit more why the sort is not getting populated? I
see you removed the ENUMERABLE rules and added Drill.CONVENTION in the
input.

Tim
On Wed, Oct 9, 2013 at 11:00 AM, Jacques Nadeau <[EMAIL PROTECTED]> wrote:

> Hey Tim,
>
> I believe I fixed the problems.  You can get it from:
>
> https://github.com/jacques-n/incubator-drill/tree/limit_op
>
>
> On Sun, Oct 6, 2013 at 1:09 PM, Timothy Chen <[EMAIL PROTECTED]> wrote:
>
>> Hi Julian,
>>
>> Do you think you can take a look sometime?
>>
>> Tim
>>
>>
>> On Sun, Sep 29, 2013 at 3:23 PM, Timothy Chen <[EMAIL PROTECTED]> wrote:
>>
>>> Btw, the code is at
>>> https://github.com/tnachen/incubator-drill/tree/limit_op
>>>
>>> Tim
>>>
>>>
>>> On Sun, Sep 29, 2013 at 3:22 PM, Timothy Chen <[EMAIL PROTECTED]> wrote:
>>>
>>>> I tried that as well earlier, but still the same result.
>>>>
>>>> It's creating the input and sorts, but in the end it won't call the
>>>> DrillImplementor for Rels at all.
>>>>
>>>>  I also tried taking out the replace, but same results too.
>>>>
>>>> It wonder if the best route (cheapest) as able to skip the one copied?
>>>>
>>>> I believe I followed mostly what you suggested that is follow
>>>> EnumerableLimitRel impl.
>>>>
>>>> Tim
>>>>
>>>>
>>>>
>>>>
>>>> On Sun, Sep 29, 2013 at 3:01 PM, Julian Hyde <[EMAIL PROTECTED]>wrote:
>>>>
>>>>>
>>>>> On Sep 28, 2013, at 1:01 AM, Timothy Chen <[EMAIL PROTECTED]> wrote:
>>>>>
>>>>> > Here is one of the trials I tried:
>>>>> >
>>>>> > -    final RelTraitSet traits >>>>> sort.getTraitSet().plus(DrillRel.CONVENTION);
>>>>> > +    final RelTraitSet traits = sort.getTraitSet();
>>>>> >     RelNode input = sort.getChild();
>>>>> >     if (!sort.getCollation().getFieldCollations().isEmpty()) {
>>>>> >       input = sort.copy(
>>>>> > -          sort.getTraitSet().replace(RelCollationImpl.EMPTY),
>>>>> > -          input,
>>>>> > -          RelCollationImpl.EMPTY,
>>>>> > +          sort.getTraitSet(),
>>>>> > +          sort,
>>>>> > +          sort.getCollation(),
>>>>> >           null,
>>>>> >           null);
>>>>> >     }
>>>>>
>>>>> The
>>>>>
>>>>>  +  sort,
>>>>>
>>>>> line should be
>>>>>
>>>>>  + input,
>>>>>
>>>>> otherwise you are creating a sort on top of a sort. Give that a try.
>>>>>
>>>>> Julian
>>>>>
>>>>>
>>>>
>>>
>>
>
+
Jacques Nadeau 2013-10-09, 18:14
+
Timothy Chen 2013-10-10, 17:52
+
Jacques Nadeau 2013-10-10, 17:57
+
Timothy Chen 2013-10-10, 18:20
+
Steven Phillips 2013-09-26, 00:00
+
Timothy Chen 2013-10-11, 03:42
+
Jacques Nadeau 2013-10-11, 18:42
+
Timothy Chen 2013-10-11, 18:58
+
Timothy Chen 2013-10-15, 16:32
+
Timothy Chen 2013-10-15, 22:50
+
Julian Hyde 2013-09-09, 19:11
+
Timothy Chen 2013-09-09, 19:29
+
Julian Hyde 2013-09-09, 19:36