Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-990: Sqoop2: Allow users to override Sqoop2's default http port and admin port


Copy link to this message
-
Re: Review Request: SQOOP-990: Sqoop2: Allow users to override Sqoop2's default http port and admin port
Jarek Cecho 2013-04-19, 21:58

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10662/#review19484
-----------------------------------------------------------
Hi Mark,
thank you very much for your effort. I do have one comment:
dist/src/main/bin/sqoop.sh
<https://reviews.apache.org/r/10662/#comment40232>

    It seems that we're overriding JAVA_OPTS variable. Would you mind preserving previous content?
Jarcec

- Jarek Cecho
On April 19, 2013, 9:47 p.m., Mark Grover wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10662/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 9:47 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Allowing users to override Sqoop2's default http port and admin port.
>
>
> This addresses bug SQOOP-990.
>     https://issues.apache.org/jira/browse/SQOOP-990
>
>
> Diffs
> -----
>
>   dist/src/main/bin/sqoop-sys.sh PRE-CREATION
>   dist/src/main/bin/sqoop.sh f1711ee
>   dist/src/main/server/bin/setenv.sh 607427e
>   dist/src/main/server/conf/server.xml 3206cce
>
> Diff: https://reviews.apache.org/r/10662/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Grover
>
>