Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Please review check-ins


Copy link to this message
-
Re: Please review check-ins
They look kosher to me

On Thu, Aug 23, 2012 at 8:25 AM, Keith Turner <[EMAIL PROTECTED]> wrote:

> I will take a look at them.  If they did not have test, then you
> probably do not need to add test when making improvements like this.
> I would recommend at least executing the code though.  Many times I
> have made what I thought were simple changes and it blew up for some
> reason.
>
> On Thu, Aug 23, 2012 at 12:01 AM, David Medinets
> <[EMAIL PROTECTED]> wrote:
> > Both of the following jira tickets are related to unclosed objects.
> > The changes were fairly simply and the code compiled after my change.
> > I did not create any tests or execute the code. If someone can do a
> > review after a 'svn update', I'd appreciate it.
> >
> > https://issues.apache.org/jira/browse/ACCUMULO-737
> > https://issues.apache.org/jira/browse/ACCUMULO-738
> >
> > Thanks
>
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB