Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-544: Split metadata between import and export related


+
Jarek Cecho 2012-08-10, 07:20
+
Jarek Cecho 2012-08-10, 19:26
+
Jarek Cecho 2012-08-13, 13:22
+
Bilung Lee 2012-08-14, 17:45
Copy link to this message
-
Re: Review Request: SQOOP-544: Split job metadata for different job types (import, export)


> On Aug. 14, 2012, 5:45 p.m., Bilung Lee wrote:
> > Ship It!

The patch on the JIRA seems to be an older one.  Could you please update it there?  Thanks!
- Bilung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6576/#review10288
-----------------------------------------------------------
On Aug. 13, 2012, 1:22 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6576/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2012, 1:22 p.m.)
>
>
> Review request for Sqoop and Bilung Lee.
>
>
> Description
> -------
>
> Job covered by this JIRA:
>
> * I've included new abstraction classes for connection and job (MConnection, MJob). Both are internally represented as List<MForm>.
> * I've included support for multiple job types (Import, Export). Solution should be open to any other new job types.
> * I'm forcing connector to supply only one set of Forms for each job type (e.g. support IMPORT twice is incorrect usage).
>
> Jarcec
>
>
> This addresses bug SQOOP-544.
>     https://issues.apache.org/jira/browse/SQOOP-544
>
>
> Diffs
> -----
>
>   /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java 1372400
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 1372400
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnection.java PRE-CREATION
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MConnector.java 1372400
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MFramework.java 1372400
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MJob.java PRE-CREATION
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MStringInput.java 1372400
>   /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/ModelError.java PRE-CREATION
>   /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java PRE-CREATION
>   /branches/sqoop2/common/src/test/java/org/apache/sqoop/model/TestMFramework.java PRE-CREATION
>   /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 1372400
>   /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java 1372400
>   /branches/sqoop2/connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java 1372400
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 1372400
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 1372400
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 1372400
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 1372400
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 1372400
>   /branches/sqoop2/spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 1372400
>
> Diff: https://reviews.apache.org/r/6576/diff/
>
>
> Testing
> -------
>
> * Added new test for MFramework instance creation
> * mvn test
> * "Life" testing
>
>
> Thanks,
>
> Jarek Cecho
>
>

+
Jarek Cecho 2012-08-14, 19:19