Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 12806: SQOOP-890: ClassWriter Generates setField Casts Based on the Output Type, not the Input Type


Copy link to this message
-
Re: Review Request 12806: SQOOP-890: ClassWriter Generates setField Casts Based on the Output Type, not the Input Type
Jarek Cecho 2013-07-28, 00:51

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12806/#review24046
-----------------------------------------------------------
I totally  see your point Nick. I still do not feel entirely comfortable about doing some data conversions without explicit user permission on a stable branch in potentially backward incompatible manner. Do you think that it would make sense to enable this behavior conditionally? We could add a new command line argument allowing "relaxed" and possibly dangerous conversions. This way user have to be explicit that it's acceptable behavior.

- Jarek Cecho
On July 24, 2013, 5:44 p.m., Nick White wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12806/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 5:44 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Sqoop should be more flexible when converting between number types.
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/orm/ClassWriter.java 1bd2a41
>   src/test/com/cloudera/sqoop/TestAvroExport.java 7016826
>
> Diff: https://reviews.apache.org/r/12806/diff/
>
>
> Testing
> -------
>
> Unit test included.
>
>
> Thanks,
>
> Nick White
>
>