Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request 14439: Syslog source strips timestamp and hostname from log message body


+
Jeff jlord 2013-10-02, 01:04
+
Mike Percy 2013-10-03, 17:15
+
Jeff jlord 2013-10-10, 00:47
+
Jeff jlord 2013-10-10, 01:13
Copy link to this message
-
Re: Review Request 14439: Syslog source strips timestamp and hostname from log message body
Mike Percy 2013-10-10, 01:08

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14439/#review26848
-----------------------------------------------------------

flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java
<https://reviews.apache.org/r/14439/#comment52206>

    Unused import

flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java
<https://reviews.apache.org/r/14439/#comment52212>

    Use Javadoc-style comments at the top of objects and functions. i.e. /** Comment. */
    
    Also, this should be indented 2 spaces.

flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java
<https://reviews.apache.org/r/14439/#comment52213>

    Nit: Only one space before the curly brace.

flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java
<https://reviews.apache.org/r/14439/#comment52214>

    One space before the curly brace.

flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java
<https://reviews.apache.org/r/14439/#comment52215>

    This block should be indented 2 spaces, not 4.

flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java
<https://reviews.apache.org/r/14439/#comment52216>

    Nit: This should go at the top of the loop, if e was null e.getBody() would have already thrown a NullPointerException.
Thanks Jeff. Looks good overall, just a couple more nits here.

- Mike Percy
On Oct. 10, 2013, 12:47 a.m., Jeff jlord wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14439/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2013, 12:47 a.m.)
>
>
> Review request for Flume.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Attaching a patch which introduces a boolean keepFields which defaults to false. When set to true this will preserve the timestamp and hostname in the body of the event. Additionally I have added a test for SyslogTcpSource
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java db9e0fd
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 2d7a429
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464
>   flume-ng-doc/sphinx/FlumeDeveloperGuide.rst 2be9c68
>   flume-ng-doc/sphinx/FlumeUserGuide.rst dac3ce7
>
> Diff: https://reviews.apache.org/r/14439/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff jlord
>
>