Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: FLUME-1849: Embedded Agent doesn't shutdown supervisor


+
Brock Noland 2013-01-16, 20:04
Copy link to this message
-
Re: Review Request: FLUME-1849: Embedded Agent doesn't shutdown supervisor
Brock Noland 2013-01-16, 20:04

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8973/
-----------------------------------------------------------

(Updated Jan. 16, 2013, 8:04 p.m.)
Review request for Flume.
Changes
-------

Updated with bug #
Description
-------

The EmbeddedAgent does not shutdown the supervisor, this was done initially so that exceptions could be caught during a components stop method. However, this causes non-daemon threads to continue to run causing the JVM to stay alive.
This addresses bug FLUME-1849.
    https://issues.apache.org/jira/browse/FLUME-1849
Diffs
-----

  flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java 4adbea7
  flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java b315770

Diff: https://reviews.apache.org/r/8973/diff/
Testing
-------

Unit tests pass. Three unit tests are removed which cannot be supported given the fact that we need to use the supervisor to do the shutdown.

I manually verified the JVM can shutdown with this patch.
Thanks,

Brock Noland

+
Hari Shreedharan 2013-01-16, 21:00