Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: Request to review patch for SQOOP-954: Create Sqoop runtime scripts to run Sqoop on Windows


+
Ahmed El Baz 2013-03-20, 23:56
+
Venkat Ranganathan 2013-03-22, 06:11
+
Ahmed El Baz 2013-03-22, 18:55
+
Jarek Cecho 2013-03-28, 22:19
+
Jarek Cecho 2013-03-22, 02:51
+
Ahmed El Baz 2013-03-22, 18:55
+
Ahmed El Baz 2013-03-29, 03:01
+
Venkat Ranganathan 2013-03-29, 19:03
+
Ahmed El Baz 2013-03-29, 22:23
+
Venkat Ranganathan 2013-04-14, 04:58
+
Venkat Ranganathan 2013-04-15, 18:21
+
Ahmed El Baz 2013-04-22, 03:29
+
Ahmed El Baz 2013-04-22, 03:26
+
Venkat Ranganathan 2013-04-22, 07:06
+
Ahmed El Baz 2013-04-22, 17:05
+
Ahmed El Baz 2013-04-23, 04:13
+
Jarek Cecho 2013-04-23, 18:38
+
Ahmed El Baz 2013-04-23, 18:43
+
Venkat Ranganathan 2013-04-23, 04:26
+
Venkat Ranganathan 2013-04-22, 23:04
+
Venkat Ranganathan 2013-04-23, 04:12
+
Ahmed El Baz 2013-04-23, 04:04
+
Ahmed El Baz 2013-04-23, 04:15
+
Venkat Ranganathan 2013-04-22, 22:49
+
Venkat Ranganathan 2013-04-22, 17:37
Copy link to this message
-
Re: Review Request: Request to review patch for SQOOP-954: Create Sqoop runtime scripts to run Sqoop on Windows


> On April 22, 2013, 5:37 p.m., Venkat Ranganathan wrote:
> > bin/configure-sqoop.cmd, line 71
> > <https://reviews.apache.org/r/10055/diff/3/?file=283030#file283030line71>
> >
> >     I am not sure I see a if exists block.   This line I checked says %HADOOP_COMMON_HOME% does not exist.   May be you are checking against a different version of the file.  But it looks like you understand the issue.   So, please fix it in the right location

Hi Venkat,

Sorry if I did not make it clear enough. I meant to say that the case undefined variables while prinitng should not happen since there are two gates (please see below).
I have copied the snippets below from the uploaded diff, so it should be uploaded fine.

1) The first one is to check if variables are not set, and set them accordingly.

if not defined HADOOP_COMMON_HOME (
 ...
)

if not defined HADOOP_MAPRED_HOME (
 ...
)

if not defined HBASE_HOME (
  ...
)
2) The second step is to verify the set paths actually exist
if not exist %HADOOP_COMMON_HOME% (
  ...
)

if not exist %HADOOP_MAPRED_HOME% (
  ...
)

if not exist "%HBASE_HOME%" (
  ...
)

Thanks,
Ahmed
> On April 22, 2013, 5:37 p.m., Venkat Ranganathan wrote:
> > bin/configure-sqoop.cmd, line 129
> > <https://reviews.apache.org/r/10055/diff/3/?file=283030#file283030line129>
> >
> >     I see a setlocal enabledelayedexpansion.   Does it also localize environment variables.   I thought it did not.

Yes, I have verified that it does not leak the environment variables with subsequent runs.
Thanks,
Ahmed
- Ahmed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10055/#review19534
-----------------------------------------------------------
On April 22, 2013, 3:26 a.m., Ahmed El Baz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10055/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 3:26 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> A patch implementing the Windows version of Sqoop run scripts. The scripts follow the same logic as there .sh counterparts.
> One difference is to create a Jar which references all classpath elements in its Manifest, and provide that jar as the single jar needed for Sqoop. The reason here is that in some cases if the number of classpath elements is large, HADOOP_CLASSPATH gets very long which causes failures in Windows since there is a limit to command lines.
> As a workaround, I added a step to wrap all jars in the classpath in a single jar, and then use that generated jar (this is also done in hadoop for Windows to handle similar issues)
> I did this in a utility script "BuildJar" which can be used for other components as well.
> This change is specific to Windows scripts, Linux scripts are not affected.
>
>
> This addresses bug SQOOP-954.
>     https://issues.apache.org/jira/browse/SQOOP-954
>
>
> Diffs
> -----
>
>   bin/configure-sqoop.cmd PRE-CREATION
>   bin/sqoop.cmd PRE-CREATION
>   conf/sqoop-env-template.cmd PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10055/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ahmed El Baz
>
>