|
|
-
Re: [VOTE] BookKeeper 4.0.0 Release Candidate 0
Patrick Hunt 2011-12-02, 17:42
-1, overall looks very close, feedback below: 0) don't call the vote on user lists, this is a development activity. Just on the bk dev and private list (only ZK PMC votes are binding). Include zk dev if you like. When the entire process is finished ff to publish to all these lists as well as [EMAIL PROTECTED] also, you only need to allow 72hours for the vote. 1) signature/checksums look good. 2) move the keys file into https://svn.apache.org/repos/asf/zookeeper/bookkeeper/dist - similar to what zk does. This shouldn't be in your source repo. not a blocker issue but you should add yourself to the web of trust asap. 3) the NOTICE.txt is unacceptable. This needs to be the Apache boilerplate, plus any third party dependencies you might have (are you shipping any third party dependencies that require notification? afaict no.), see http://www.apache.org/legal/src-headers.htmlspecifically the section "NOTICE file" 4) readme looks good 5) mvn test passed 6) licensing -- RAT looks good. Cleanup these small issues then call a new vote on a second RC and you should be good. Patrick On Thu, Dec 1, 2011 at 11:48 PM, Ivan Kelly <[EMAIL PROTECTED]> wrote: > This is the first candidate release for Apache BookKeeper, version > 4.0.0. > > It fixes the following issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311293&version=12317843> > *** Please download, test and vote by December 7th 2011, 08:00 GMT. > > Note that we are voting upon the source (tag), binaries are provided > for convenience. > > Source and binary files: > http://people.apache.org/~ivank/bookkeeper-4.0.0-candidate-0/> > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachebookkeeper-285/> > The tag to be voted upon: > https://svn.apache.org/repos/asf/zookeeper/bookkeeper/tags/release-4.0.0/> > BookKeeper's KEYS file containing PGP keys we use to sign the release: > https://svn.apache.org/repos/asf/zookeeper/bookkeeper/tags/release-4.0.0/KEYS> > Please download the the source package, and follow the README to build > and run a bookkeeper and hedwig service.
-
Re: [VOTE] BookKeeper 4.0.0 Release Candidate 1
Patrick Hunt 2011-12-05, 18:04
Yes. See this section: http://incubator.apache.org/guides/releasemanagement.html#best-practice-licenseI'm not sure if this changed btw when Hadoop/ZK started and current documentation, notice that it says to include in the license file. What hadoop/zk do is to include individual license files in the "lib" directory, along side the jars themselves. We probably should change this in zk to be in compliance. Patrick On Sun, Dec 4, 2011 at 8:52 PM, Benjamin Reed <[EMAIL PROTECTED]> wrote: > +1 this looks great ivan! excellent work. > > i do have one question for pat. in the binary tar files do we have to > put in something special for the licenses of the included binaries? > > ben > > On Fri, Dec 2, 2011 at 12:13 PM, Ivan Kelly <[EMAIL PROTECTED]> wrote: >> This is the second candidate release for Apache BookKeeper, version >> 4.0.0. >> >> It fixes the following issues: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311293&version=12317843>> >> *** Please download, test and vote by December 5th 2011, 21:00 GMT. >> >> Note that we are voting upon the source (tag), binaries are provided >> for convenience. >> >> Source and binary files: >> http://people.apache.org/~ivank/bookkeeper-4.0.0-candidate-1/>> >> Maven staging repo: >> https://repository.apache.org/content/repositories/orgapachebookkeeper-287/>> >> The tag to be voted upon: >> https://svn.apache.org/repos/asf/zookeeper/bookkeeper/tags/release-4.0.0/>> >> BookKeeper's KEYS file containing PGP keys we use to sign the release: >> https://svn.apache.org/repos/asf/zookeeper/bookkeeper/dist/KEYS>> >> Please download the the source package, and follow the README to build >> and run a bookkeeper and hedwig service.
-
Re: [VOTE] BookKeeper 4.0.0 Release Candidate 1
Patrick Hunt 2011-12-05, 18:13
+1, the sig/checksums look good, RAT is ok and the notice seems correct. Great job! On Fri, Dec 2, 2011 at 12:13 PM, Ivan Kelly <[EMAIL PROTECTED]> wrote: > This is the second candidate release for Apache BookKeeper, version > 4.0.0. > > It fixes the following issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311293&version=12317843> > *** Please download, test and vote by December 5th 2011, 21:00 GMT. > > Note that we are voting upon the source (tag), binaries are provided > for convenience. > > Source and binary files: > http://people.apache.org/~ivank/bookkeeper-4.0.0-candidate-1/> > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachebookkeeper-287/> > The tag to be voted upon: > https://svn.apache.org/repos/asf/zookeeper/bookkeeper/tags/release-4.0.0/> > BookKeeper's KEYS file containing PGP keys we use to sign the release: > https://svn.apache.org/repos/asf/zookeeper/bookkeeper/dist/KEYS> > Please download the the source package, and follow the README to build > and run a bookkeeper and hedwig service.
-
Re: [VOTE] BookKeeper 4.0.0 Release Candidate 1
Ivan Kelly 2011-12-06, 10:49
I've updated the binary packages to include licenses for all included jars. Attached for convenience.
> I'm not sure if this changed btw when Hadoop/ZK started and current > documentation, notice that it says to include in the license file. > What hadoop/zk do is to include individual license files in the "lib" > directory, along side the jars themselves. We probably should change > this in zk to be in compliance. Individual license files will probably be hard to do in maven, as the lib directory will not exist in the source.
-Ivan
-
Re: [VOTE] BookKeeper 4.0.0 Release Candidate 1
Flavio Junqueira 2011-12-06, 15:11
+1, I have run unit tests, some manual tests, and gone through the release checklist. -Flavio On Dec 5, 2011, at 7:13 PM, Patrick Hunt wrote: > +1, the sig/checksums look good, RAT is ok and the notice seems > correct. Great job! > > On Fri, Dec 2, 2011 at 12:13 PM, Ivan Kelly <[EMAIL PROTECTED]> wrote: >> This is the second candidate release for Apache BookKeeper, version >> 4.0.0. >> >> It fixes the following issues: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311293&version=12317843>> >> *** Please download, test and vote by December 5th 2011, 21:00 GMT. >> >> Note that we are voting upon the source (tag), binaries are provided >> for convenience. >> >> Source and binary files: >> http://people.apache.org/~ivank/bookkeeper-4.0.0-candidate-1/>> >> Maven staging repo: >> https://repository.apache.org/content/repositories/orgapachebookkeeper-287/>> >> The tag to be voted upon: >> https://svn.apache.org/repos/asf/zookeeper/bookkeeper/tags/release-4.0.0/>> >> BookKeeper's KEYS file containing PGP keys we use to sign the >> release: >> https://svn.apache.org/repos/asf/zookeeper/bookkeeper/dist/KEYS>> >> Please download the the source package, and follow the README to >> build >> and run a bookkeeper and hedwig service. flavio junqueira research scientist [EMAIL PROTECTED] direct +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, es phone (408) 349 3300 fax (408) 349 3301
-
Re: [VOTE] BookKeeper 4.0.0 Release Candidate 1
Flavio Junqueira 2011-12-06, 15:17
I'm confused now. If you change the candidate files, then we have to call for a new vote, no?
-Flavio
On Dec 6, 2011, at 11:49 AM, Ivan Kelly wrote:
> I've updated the binary packages to include licenses for all included > jars. Attached for convenience. > >> I'm not sure if this changed btw when Hadoop/ZK started and current >> documentation, notice that it says to include in the license file. >> What hadoop/zk do is to include individual license files in the "lib" >> directory, along side the jars themselves. We probably should change >> this in zk to be in compliance. > Individual license files will probably be hard to do in maven, as the > lib directory will not exist in the source. > > -Ivan
flavio junqueira
research scientist
[EMAIL PROTECTED] direct +34 93-183-8828
avinguda diagonal 177, 8th floor, barcelona, 08018, es phone (408) 349 3300 fax (408) 349 3301
-
Re: [VOTE] BookKeeper 4.0.0 Release Candidate 1
Flavio Junqueira 2011-12-06, 15:41
I missed initially that the changes are only to the binary packages. It doesn't sound like we need to call a new vote.
-Flavio
On Dec 6, 2011, at 4:17 PM, Flavio Junqueira wrote:
> I'm confused now. If you change the candidate files, then we have to > call for a new vote, no? > > -Flavio > > On Dec 6, 2011, at 11:49 AM, Ivan Kelly wrote: > >> I've updated the binary packages to include licenses for all included >> jars. Attached for convenience. >> >>> I'm not sure if this changed btw when Hadoop/ZK started and current >>> documentation, notice that it says to include in the license file. >>> What hadoop/zk do is to include individual license files in the >>> "lib" >>> directory, along side the jars themselves. We probably should change >>> this in zk to be in compliance. >> Individual license files will probably be hard to do in maven, as the >> lib directory will not exist in the source. >> >> -Ivan > > flavio > junqueira > > research scientist > > [EMAIL PROTECTED] > direct +34 93-183-8828 > > avinguda diagonal 177, 8th floor, barcelona, 08018, es > phone (408) 349 3300 fax (408) 349 3301 >
flavio junqueira
research scientist
[EMAIL PROTECTED] direct +34 93-183-8828
avinguda diagonal 177, 8th floor, barcelona, 08018, es phone (408) 349 3300 fax (408) 349 3301
-
Re: [VOTE] BookKeeper 4.0.0 Release Candidate 1
ivank@... 2011-12-06, 16:24
I forgot to attach the files. Attached now
-Ivan
On Tue, Dec 06, 2011 at 11:49:33AM +0100, Ivan Kelly wrote: > I've updated the binary packages to include licenses for all included > jars. Attached for convenience. > > > I'm not sure if this changed btw when Hadoop/ZK started and current > > documentation, notice that it says to include in the license file. > > What hadoop/zk do is to include individual license files in the "lib" > > directory, along side the jars themselves. We probably should change > > this in zk to be in compliance. > Individual license files will probably be hard to do in maven, as the > lib directory will not exist in the source. > > -Ivan
-
Re: [VOTE] BookKeeper 4.0.0 Release Candidate 1
Ivan Kelly 2011-12-06, 17:15
The vote has passed with three binding +1 from phunt, breed & fpj. I'll push out the list to dist and maven. Once the mirrors have synced, I'll update the website and send out an announcement. Thanks for taking a look guys, -Ivan On Fri, Dec 02, 2011 at 09:13:48PM +0100, Ivan Kelly wrote: > This is the second candidate release for Apache BookKeeper, version > 4.0.0. > > It fixes the following issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311293&version=12317843> > *** Please download, test and vote by December 5th 2011, 21:00 GMT. > > Note that we are voting upon the source (tag), binaries are provided > for convenience. > > Source and binary files: > http://people.apache.org/~ivank/bookkeeper-4.0.0-candidate-1/> > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachebookkeeper-287/> > The tag to be voted upon: > https://svn.apache.org/repos/asf/zookeeper/bookkeeper/tags/release-4.0.0/> > BookKeeper's KEYS file containing PGP keys we use to sign the release: > https://svn.apache.org/repos/asf/zookeeper/bookkeeper/dist/KEYS> > Please download the the source package, and follow the README to build > and run a bookkeeper and hedwig service.
|
|