Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig >> mail # dev >> Review Request 13551: PIG-3414 Utils.getSchemaFromString() silently returns a wrong result when a comma is missing in the schema definition


Copy link to this message
-
Review Request 13551: PIG-3414 Utils.getSchemaFromString() silently returns a wrong result when a comma is missing in the schema definition

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13551/
-----------------------------------------------------------

Review request for pig.
Bugs: PIG-3414
    https://issues.apache.org/jira/browse/PIG-3414
Repository: pig-git
Description
-------

I updated the schema parsing grammar, so an invalid schema string throws a parser exception rather than silently returns partial schema.

While running the unit tests, I found and fixed bugs in the following unit tests:
TestSchema
TestSchemaTuple
TestPOCast
Diffs
-----

  src/org/apache/pig/parser/QueryParser.g 6040389
  src/org/apache/pig/parser/QueryParserDriver.java bdad431
  test/org/apache/pig/data/TestSchemaTuple.java 212c00a
  test/org/apache/pig/test/TestPOCast.java b6c395f
  test/org/apache/pig/test/TestSchema.java bfe76c4

Diff: https://reviews.apache.org/r/13551/diff/
Testing
-------

Added a new test case to TestSchema.

All the unit tests pass.
Thanks,

Cheolsoo Park

+
Rohini Palaniswamy 2013-08-14, 17:08