Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: Sqoop2: Show connection and job command hung


+
rj.vasanthkumar@... 2013-04-07, 22:27
+
Jarek Cecho 2013-04-13, 18:56
Copy link to this message
-
Re: Review Request: Sqoop2: Show connection and job command hung


> On April 13, 2013, 6:56 p.m., Jarek Cecho wrote:
> > Hi Vasanth,
> > thank you very much for catching this one. We're clearly not properly closing all opened statements. It seems that we're creating the PreparedStatements inside the while loop which seems quite inefficient. What about creating the statements outside of the while loop and reuse them?
> >
> > Jarcec

yes we can resue them.
- vasanthkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10331/#review19126
-----------------------------------------------------------
On April 7, 2013, 10:27 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10331/
> -----------------------------------------------------------
>
> (Updated April 7, 2013, 10:27 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Show connection and job command hung when connection or job records size more than 8.
> Problem while invoking prepareStatement method.
>
>
> This addresses bug sqoop-980.
>     https://issues.apache.org/jira/browse/sqoop-980
>
>
> Diffs
> -----
>
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 486635d
>
> Diff: https://reviews.apache.org/r/10331/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>

+
rj.vasanthkumar@... 2013-04-13, 20:53
+
Jarek Cecho 2013-04-13, 22:04