Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request 14027: Adding Limit operator end to end


Copy link to this message
-
Re: Review Request 14027: Adding Limit operator end to end
Timothy Chen 2013-10-11, 18:58

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14027/#review26938
-----------------------------------------------------------

exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java
<https://reviews.apache.org/r/14027/#comment52467>

    I thought I handled that by overriding next() and return the outcome right away if I have enough records read for this limit. Does this not skip reading incoming batches or I'm missing something again?
- Timothy Chen
On Oct. 11, 2013, 3:42 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14027/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 3:42 a.m.)
>
>
> Review request for drill and Jacques Nadeau.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Adding Limit operator end to end
>
>
> Diffs
> -----
>
>   LICENSE 5234110
>   common/src/main/java/org/apache/drill/common/JSONOptions.java 8157dc6
>   common/src/main/java/org/apache/drill/common/logical/data/Constant.java e05ce41
>   common/src/main/java/org/apache/drill/common/logical/data/Limit.java 93eb182
>   common/src/main/java/org/apache/drill/common/logical/data/LogicalOperator.java 9810e75
>   common/src/main/java/org/apache/drill/common/logical/data/LogicalOperatorBase.java 29c994f
>   exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java 5a1fd6e
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java 286144b
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java a36b65a
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Limit.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 94acc0e
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitBatchCreator.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java 0368d0c
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java PRE-CREATION
>   exec/java-exec/src/test/resources/limit/test1.json PRE-CREATION
>   exec/java-exec/src/test/resources/limit/test2.json PRE-CREATION
>   exec/java-exec/src/test/resources/limit/test3.json PRE-CREATION
>   exec/ref/src/main/java/org/apache/drill/exec/ref/rops/LimitROP.java 00baf81
>   pom.xml ce1f93d
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillImplementor.java 6efe60b
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillLimitRel.java PRE-CREATION
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillLimitRule.java PRE-CREATION
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillOptiq.java b01aa7d
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillPrepareImpl.java 363c064
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillSortRel.java b2e9b50
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillSortRule.java d5eac2e
>   sqlparser/src/test/java/org/apache/drill/jdbc/test/FullEngineTest.java 45d1ff3
>   sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java e78d5c7
>   sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcTest.java 36b024c
>
> Diff: https://reviews.apache.org/r/14027/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>