Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1765 - Add Load Balancing Support to Log4jAppender


+
Cameron Gandevia 2012-12-03, 20:52
Copy link to this message
-
Re: Review Request: FLUME-1765 - Add Load Balancing Support to Log4jAppender

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8328/#review14008
-----------------------------------------------------------
Does not look like you are creating LoadBalancingRpcClient anywhere. Also I don't think there is a need for more getInstance methods, just use the one currently available - pass in a properties instance.

- Hari Shreedharan
On Dec. 3, 2012, 8:52 p.m., Cameron Gandevia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8328/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2012, 8:52 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> The Log4jAppender should be extended to use the LoadBalancingRpcClient allowing users to configure a load balancing log4jappender
>
>
> Diffs
> -----
>
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1
>   flume-ng-doc/sphinx/FlumeUserGuide.rst f8528bb
>   flume-ng-sdk/src/main/java/org/apache/flume/api/HostInfo.java 7388a45
>   flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java 3c93921
>
> Diff: https://reviews.apache.org/r/8328/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Cameron Gandevia
>
>

+
Cameron Gandevia 2012-12-07, 20:12
+
Hari Shreedharan 2012-12-10, 19:45
+
Brock Noland 2012-12-21, 18:02
+
Hari Shreedharan 2012-12-22, 22:54
+
Hari Shreedharan 2013-01-03, 23:44
+
Hari Shreedharan 2013-01-04, 02:53
+
Cameron Gandevia 2013-01-18, 02:29
+
Hari Shreedharan 2013-01-22, 06:03
+
Cameron Gandevia 2013-01-18, 02:17
+
Hari Shreedharan 2013-01-22, 06:07
+
Hari Shreedharan 2013-01-22, 07:02
+
Cameron Gandevia 2013-01-22, 22:09
+
Cameron Gandevia 2013-02-21, 22:43
+
Hari Shreedharan 2013-02-21, 22:46
+
Cameron Gandevia 2013-02-22, 01:38
+
Hari Shreedharan 2013-01-23, 05:08