Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager


+
Mengwei Ding 2013-06-17, 22:33
+
Jarek Cecho 2013-06-18, 14:51
+
Mengwei Ding 2013-06-19, 00:17
+
Mengwei Ding 2013-06-19, 00:48
+
Mengwei Ding 2013-06-19, 00:58
+
Mengwei Ding 2013-06-19, 01:06
Copy link to this message
-
Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11920/#review22137
-----------------------------------------------------------
Hi Mengwe,
thank you very much for incorporating my suggestions! I do have last couple of nits:
core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
<https://reviews.apache.org/r/11920/#comment45542>

    Nit: I would advise to not print out the lines with equals signs I do understand that we are trying to make the messages more visible, however I'm afraid that it will have the opposite effect as we will most likely print several of such messages and the log will be full of equal sings.
    Nit: I would promote those messages to warning.

core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java
<https://reviews.apache.org/r/11920/#comment45543>

    I do not feel comfortable about swallowing IllegalStateException. Do we have a reason why to catch it? Would it be simpler to let it propagate and kill the server? Anyway Sqoop server can't work without the repository right?
- Jarek Cecho
On June 19, 2013, 1:06 a.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11920/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 1:06 a.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 7fc5ae741cbe74e3f9aa50138dadfc3fdb594cbd
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Wed Jun 12 15:47:26 2013 -0700
>
>     SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager
>
> :100644 100644 500189a... 0540f6b... M core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
> :100644 100644 f59d132... eb7c1dc... M core/src/main/java/org/apache/sqoop/core/CoreError.java
> :000000 100644 0000000... d25ce41... A core/src/main/java/org/apache/sqoop/core/Reconfigurable.java
> :100644 100644 deb24c9... c34ab37... M core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
> :100644 100644 145a2c1... bfe0971... M core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
> :100644 100644 3339c59... 7f47326... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java
> :100644 100644 955306d... 88667f2... M core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java
> :100644 100644 4ea52e9... 1ec6bdf... M core/src/main/java/org/apache/sqoop/repository/RepositoryProvider.java
> :100644 100644 de9a24b... ae8686b... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
>
>
> This addresses bug SQOOP-971.
>     https://issues.apache.org/jira/browse/SQOOP-971
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 500189a
>   core/src/main/java/org/apache/sqoop/core/CoreError.java f59d132
>   core/src/main/java/org/apache/sqoop/core/Reconfigurable.java PRE-CREATION
>   core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java deb24c9
>   core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 145a2c1
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java 3339c59
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 955306d
>   core/src/main/java/org/apache/sqoop/repository/RepositoryProvider.java 4ea52e9
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java de9a24b
>
> Diff: https://reviews.apache.org/r/11920/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>

+
Mengwei Ding 2013-06-21, 18:12
+
Jarek Cecho 2013-06-21, 19:39
+
Mengwei Ding 2013-06-21, 20:42
+
Jarek Cecho 2013-06-21, 23:12