Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase, mail # dev - maintaining stable HBase build


Copy link to this message
-
Re: maintaining stable HBase build
Ramakrishna S Vasudevan 0... 2011-09-24, 16:16
Hi

Ted, I agree with you.  Pasting the testcase results in JIRA is also fine, mainly when there are some testcase failures when we run locally but if we feel it is not due to the fix we have added we can mention that also.  I think rather than in a windows machine its better to run in linux box.

+1 for your suggestion Ted.  

Can we add the feature like in HDFS when we submit patch automatically the Jenkin's run the testcases?

Atleast till this is done I go with your suggestion.

Regards
Ram

----- Original Message -----
From: Ted Yu <[EMAIL PROTECTED]>
Date: Saturday, September 24, 2011 4:22 pm
Subject: maintaining stable HBase build
To: dev@hbase.apache.org

> Hi,
> I want to bring the importance of maintaining stable HBase build to
> ourattention.
> A stable HBase build is important, not just for the next release
> but also
> for authors of the pending patches to verify the correctness of
> their work.
>
> At some time on Thursday (Sept 22nd) 0.90, 0.92 and TRUNK builds
> were all
> blue. Now they're all red.
>
> I don't mind fixing Jenkins build. But if we collectively adopt
> some good
> practice, it would be easier to achieve the goal of having stable
> builds.
> For contributors, I understand that it takes so much time to run
> whole test
> suite that he/she may not have the luxury of doing this - Apache
> Jenkinswouldn't do it when you press Submit Patch button.
> If this is the case (let's call it scenario A), please use Eclipse
> (or other
> tool) to identify tests that exercise the classes/methods in your
> patch and
> run them. Also clearly state what tests you ran in the JIRA.
>
> If you have a Linux box where you can run whole test suite, it
> would be nice
> to utilize such resource and run whole suite. Then please state
> this fact on
> the JIRA as well.
> Considering Todd's suggestion of holding off commit for 24 hours
> after code
> review, 2 hour test run isn't that long.
>
> Sometimes you may see the following (from 0.92 build 18):
>
> Tests run: 1004, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] -------------------------------------------------------------
> -----------
> [INFO] BUILD FAILURE
> [INFO] -------------------------------------------------------------
> -----------
> [INFO] Total time: 1:51:41.797s
>
> You should examine the test summary above these lines and find out
> which test(s) hung. For this case it was TestMasterFailover:
>
> Running org.apache.hadoop.hbase.master.TestMasterFailover
> Running
> org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTableTests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.265 sec
>
> I think a script should be developed that parses test output and
> identify hanging test(s).
>
> For scenario A, I hope committer would run test suite.
> The net effect would be a statement on the JIRA, saying all tests
> passed.
> Your comments/suggestions are welcome.
>