Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka >> mail # dev >> whitespace


+
Jay Kreps 2012-09-18, 21:35
+
Neha Narkhede 2012-09-18, 21:42
+
Prashanth Menon 2012-09-18, 22:01
+
Joel Koshy 2012-09-18, 22:52
+
Swapnil Ghike 2012-09-18, 22:54
+
Jun Rao 2012-09-19, 01:51
+
Jun Rao 2012-09-26, 17:57
+
Jay Kreps 2012-09-26, 21:42
Copy link to this message
-
Re: whitespace
I am a fan of consistency

http://twitter.github.com/effectivescala/ works for me though I a don't
have a strong opinion to using this or another but we need to have a
consensus!

On Wed, Sep 26, 2012 at 5:42 PM, Jay Kreps <[EMAIL PROTECTED]> wrote:

> I also liked Prashanth's suggestion of standardizing a few other aspects of
> style.
>
> One option would be to just adopt an existing style guide off the shelf.
> There is one from twitter and a few other places. I think that might be an
> easy way to go. We could use whatever whitespace style they have.
>
> If we want to do a custom style guide then I guess we should just file a
> JIRA to improve the existing style guidelines and try to get consensus on
> various aspects.
>
> -Jay
>
> On Wed, Sep 26, 2012 at 10:57 AM, Jun Rao <[EMAIL PROTECTED]> wrote:
>
> > Not sure if we reached any consensus here. It seems like a tie: 3 votes
> for
> > A and 3 votes for B. Any other people want to chime in to break the tie
> :)?
> >
> > Thanks,
> >
> > Jun
> >
> > On Tue, Sep 18, 2012 at 2:35 PM, Jay Kreps <[EMAIL PROTECTED]> wrote:
> >
> > > The original code was in the style
> > >    for(x <- lst) {..}
> > > A lot of newer code looks like
> > >    for (x <- lst) {...}
> > > Some code also occasionally does
> > >    for ( x <- lst ) {...}
> > >
> > > This is not a big deal but because I am obsessive compulsive I must
> make
> > > all whitespace in a given file consistent. This results in big patches
> > with
> > > mostly trivial changes. Can we standardize on one of the above and
> > > opportunistically convert towards it?
> > >
> > > Let's call the above A, B, and C respectively. I vote for A, but am
> > pretty
> > > cool with B too.
> > >
> > > -Jay
> > >
> >
>

--

/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB