Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 13636: SQOOP-1170: Can't import columns with name "public"


Copy link to this message
-
Re: Review Request 13636: SQOOP-1170: Can't import columns with name "public"
Jarek Cecho 2013-08-22, 21:57


> On Aug. 22, 2013, 3:47 p.m., Jarek Cecho wrote:
> > That is awesome, thank you very much for the changes. I did look at current list of keywords of java on following webpage:
> >
> > http://docs.oracle.com/javase/tutorial/java/nutsandbolts/_keywords.html
> >
> > It seems to me that we are still missing three keywords - false, null and true. Would you mind adding them?
>
> Erik Selin wrote:
>     Look again ;)

Sorry Erik, my quickly written shell sniplet for parsing the values and doing the comparison have obviously some bugs :-)
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25415
-----------------------------------------------------------
On Aug. 19, 2013, 10:59 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 10:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables with columns named "public".
>
>
> Diffs
> -----
>
>   src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
>   src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
>   src/test/com/cloudera/sqoop/orm/TestClassWriter.java 358f3fc
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>