Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Review Request: PIG-3096 Make PigUnit thread safe


Copy link to this message
-
Re: Review Request: PIG-3096 Make PigUnit thread safe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8631/#review14704
-----------------------------------------------------------

Ship it!
Ship It!

- Bill Graham
On Dec. 17, 2012, 1:34 a.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8631/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2012, 1:34 a.m.)
>
>
> Review request for pig and Santhosh Srinivasan.
>
>
> Description
> -------
>
> Currently, PigUnit is not thread-safe because Cluster and PigServer are declared as static. Converting them to ThreadLocal allows PigUnit to run in multi-threaded environment.
>
>
> This addresses bug PIG-3096.
>     https://issues.apache.org/jira/browse/PIG-3096
>
>
> Diffs
> -----
>
>   test/org/apache/pig/pigunit/PigTest.java 50a5c79
>
> Diff: https://reviews.apache.org/r/8631/diff/
>
>
> Testing
> -------
>
> ant test -Dtestcase=TestPigTest
>
> I also tested it by running multiple PigUnit cases in parallel with tempus-fugit (http://tempusfugitlibrary.org/documentation/junit/parallel/) on a real cluster.
>
>
> Thanks,
>
> Cheolsoo Park
>
>