Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 16171: HIVE-5679 add date support to metastore JDO/SQL


Copy link to this message
-
Re: Review Request 16171: HIVE-5679 add date support to metastore JDO/SQL

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16171/#review31453
-----------------------------------------------------------

metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/16171/#comment59945>

    I wonder if we should support pushdown for different types. I guess for first cut, it might be sufficient to just support pushdown when value type and column type exactly match.
    Problem in being lenient by such implicit conversions is there could be bugs which users might run into it. If exact match suffices, than we don't need to worry about this code path. If there is demand for implicit conversion it can always be added later on.

metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/16171/#comment59946>

    Seems like  we can remove this debug code now.

metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g
<https://reviews.apache.org/r/16171/#comment59947>

    Is this still true? I thought you figured out a way to do this in parser by doing look ahead.

ql/src/test/queries/clientpositive/partition_date.q
<https://reviews.apache.org/r/16171/#comment59948>

    Any specific reason to change type of region column?
- Ashutosh Chauhan
On Dec. 11, 2013, 7:41 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16171/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 7:41 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java a98d9d1
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
>   metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java 93e9942
>   metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g 00e90cb
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 4b7fc73
>   ql/src/test/queries/clientpositive/partition_date.q 3c031db
>   ql/src/test/results/clientpositive/partition_date.q.out 3462a1b
>
> Diff: https://reviews.apache.org/r/16171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>