Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill, mail # dev - Review Request 13489: JsonRecordReader changes and working e2e


Copy link to this message
-
Review Request 13489: JsonRecordReader changes and working e2e
Timothy Chen 2013-08-12, 05:00

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13489/
-----------------------------------------------------------

Review request for drill and Jacques Nadeau.
Repository: drill-git
Description
-------

- Added JsonScanBatch and POP
- Added Repeated support for JsonRecordReader
- Support Late field type binding
- JsonRecordReader working e2e!
Diffs
-----

  sandbox/prototype/common/src/main/java/org/apache/drill/common/expression/SchemaPath.java 19d1069
  sandbox/prototype/common/src/main/java/org/apache/drill/common/types/Types.java e81bc89
  sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/NullableValueVectors.java ca222df
  sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/RepeatedValueVectors.java 1afe84b
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/JSONScanBatchCreator.java PRE-CREATION
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/JSONScanPOP.java PRE-CREATION
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java c31e9e4
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/DiffSchema.java b654a92
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/Field.java 85bbdf3
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/json/jackson/JacksonHelper.java 0e2c052
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/JSONRecordReader.java f72b519
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java d594b9e
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java 69c17f4
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/FixedWidthVector.java 17e072b
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java PRE-CREATION
  sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFragmentRun.java e21289c
  sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/store/JSONRecordReaderTest.java 0ebb529
  sandbox/prototype/exec/java-exec/src/test/resources/physical_json_scan_test1.json PRE-CREATION
  sandbox/prototype/exec/java-exec/src/test/resources/scan_json_test_4.json 0fb3202
  sandbox/prototype/exec/java-exec/src/test/resources/scan_json_test_5.json ae1aaf2

Diff: https://reviews.apache.org/r/13489/diff/
Testing
-------
Thanks,

Timothy Chen

+
Timothy Chen 2013-08-12, 05:02
+
Ben Becker 2013-08-13, 07:11
+
Jacques Nadeau 2013-08-13, 18:05
+
Timothy Chen 2013-08-24, 09:31