Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive, mail # dev - Review Request 16184: Hive should be able to skip header and footer rows when reading data file for a table (HIVE-5795)


+
Shuaishuai Nie 2013-12-11, 21:19
Copy link to this message
-
Re: Review Request 16184: Hive should be able to skip header and footer rows when reading data file for a table (HIVE-5795)
Eric Hanson 2013-12-16, 22:23

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16184/#review30489
-----------------------------------------------------------

common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/16184/#comment58323>

    fix comment to say "max number of lines of footer user can set for a table file"

ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/16184/#comment58324>

    Please use block comment style for multi-line comments. Please use full sentences and proper punctuation (start with capital letter, end with period).
- Eric Hanson
On Dec. 11, 2013, 9:19 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16184/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 9:19 p.m.)
>
>
> Review request for hive, Eric Hanson and Thejas Nair.
>
>
> Bugs: hive-5795
>     https://issues.apache.org/jira/browse/hive-5795
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive should be able to skip header and footer rows when reading data file for a table
> (follow up with review https://reviews.apache.org/r/15663/diff/#index_header)
>
>
> Diffs
> -----
>
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fa3e048
>   conf/hive-default.xml.template c61a0bb
>   data/files/header_footer_table_1/0001.txt PRE-CREATION
>   data/files/header_footer_table_1/0002.txt PRE-CREATION
>   data/files/header_footer_table_1/0003.txt PRE-CREATION
>   data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION
>   data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION
>   data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION
>   itests/qtest/pom.xml c3cbb89
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java d2b2526
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 974a5d6
>   ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975
>   ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b
>   ql/src/test/queries/clientnegative/file_with_header_footer_negative.q PRE-CREATION
>   ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
>   ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out PRE-CREATION
>   ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
>   serde/if/serde.thrift 2ceb572
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java 22a6168
>
> Diff: https://reviews.apache.org/r/16184/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Shuaishuai Nie
>
>

+
Thejas Nair 2013-12-17, 08:39
+
Thejas Nair 2013-12-17, 05:53
+
Shuaishuai Nie 2013-12-19, 00:40
+
Thejas Nair 2013-12-26, 18:38
+
Thejas Nair 2013-12-26, 18:31
+
Shuaishuai Nie 2013-12-30, 22:41
+
Shuaishuai Nie 2013-12-31, 23:04