Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: Patch for SQOOP-474


Copy link to this message
-
Re: Review Request: Patch for SQOOP-474
Bilung Lee 2012-04-05, 22:32

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4614/#review6721
-----------------------------------------------------------

Ship it!
- Bilung
On 2012-04-05 22:14:27, Kathleen Ting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4614/
> -----------------------------------------------------------
>
> (Updated 2012-04-05 22:14:27)
>
>
> Review request for Sqoop and Bilung Lee.
>
>
> Summary
> -------
>
> Before triggering the bounding value query construction, in addition to checking that the user has specified a split by option, also take into account that the number of mappers is 1.
>
>
> This addresses bug SQOOP-474.
>     https://issues.apache.org/jira/browse/SQOOP-474
>
>
> Diffs
> -----
>
>   ./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1309506
>
> Diff: https://reviews.apache.org/r/4614/diff
>
>
> Testing
> -------
>
> Ran unit tests. Confirmed that, with the fix, the console output does not have the boundary query in it (i.e. INFO db.DataDrivenDBInputFormat: BoundingValsQuery).
>
>
> Thanks,
>
> Kathleen
>
>