Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1763: FileChannel Checkpoints should not be done without free space


Copy link to this message
-
Re: Review Request: FLUME-1763: FileChannel Checkpoints should not be done without free space
Brock Noland 2012-12-10, 23:29


> On Dec. 10, 2012, 9:54 p.m., Hari Shreedharan wrote:
> > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java, lines 236-237
> > <https://reviews.apache.org/r/8379/diff/3/?file=235050#file235050line236>
> >
> >     Looks like you are checking for min of the configured value and FileChannelConfiguration.FLOOR_MINIMUM_REQUIRED_SPACE in FileChannel.java and you are checking the max of that value and FileChannelConfiguration.FLOOR_MINIMUM_REQUIRED_SPACE. Doing both these together means that minimumRequiredSpace is always equal to FileChannelConfiguration.FLOOR_MINIMUM_REQUIRED_SPACE. Am I missing something here?

Good catch! We should have been taking the max in FileChannel.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8379/#review14267
-----------------------------------------------------------
On Dec. 10, 2012, 11:28 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8379/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 11:28 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Adds a parameter which can be configured by defaults to 500MB. We will refuse to checkpoint or perform log writes in this case.
>
>
> This addresses bug FLUME-1763.
>     https://issues.apache.org/jira/browse/FLUME-1763
>
>
> Diffs
> -----
>
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 64a1350
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 92cad77
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 6d1cf51
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java a165d6a
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 21ca5cc
>
> Diff: https://reviews.apache.org/r/8379/diff/
>
>
> Testing
> -------
>
> Two unit tests added.
>
>
> Thanks,
>
> Brock Noland
>
>