Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Zookeeper >> mail # dev >> [DISCUSS] Patch available backlog

Flavio Junqueira 2013-05-09, 21:41
Patrick Hunt 2013-05-10, 15:53
Benjamin Reed 2013-05-10, 15:57
Edward Ribeiro 2013-05-13, 17:01
Copy link to this message
RE: [DISCUSS] Patch available backlog
Thanks for the feedback so far. The specific patches you people brought up
are fine with me, they look like important new features and I'd be happy to
have them in. I'm more concerned about the backlog problem in general,
though. There are patches that have been sitting there for a long time and
it would be nice to get to a resolution of what to do with them, not
necessarily committing.

The irc idea was simply to make it easier for people to coordinate on what
to review and such, but it sounds like it didn't get a lot of traction, so I
suggest we don't do that for now. I'll try to use irc more, though, in the
case anyone is interested in a discussion. For the ones willing to do
reviews, I'd suggest  to go over the list of patch availables on jira and
pick the ones you'd feel comfortable reviewing. This is a hint more for the
people new to the community like German, since many people here already know
the procedure.

I'll also go over the list and poke people explicitly, I hope you don't


-----Original Message-----
From: Edward Ribeiro [mailto:[EMAIL PROTECTED]]
Sent: 13 May 2013 18:02
Subject: Re: [DISCUSS] Patch available backlog

Agree with Patrick and, in my opinion, Thawan's "local session" patch and
Skye's jetty support should be high priority on list. After Alex's dynamic
config, those two patches should be evaluated asap.

I have been reviewing both patches at Review Board, as far as my n00b
knowledge of ZK inner works permits, but I'd love to see more patches at
review board! I am glad to help so let's get it started. Count me in!

Edward Ribeiro
On Fri, May 10, 2013 at 12:57 PM, Benjamin Reed <[EMAIL PROTECTED]> wrote:

> tues-thurs evenings next week would work for me.
> ben
> On Fri, May 10, 2013 at 8:53 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> > On Thu, May 9, 2013 at 2:41 PM, Flavio Junqueira
> > wrote:
> > > I was checking the issues on jira and I realized that we have
> > > currently
> > 76 patch available issues. This is a fairly large number and I'd
> > like
> some
> > help to get that number down. One way is to split issues among the
> > folks willing to review patches. It would be great to have
> > committers signing
> up
> > to review patches, but we can definitely get contributors helping
> > with
> the
> > reviews and I actually encourage reviews from contributors as well.
> > >
> >
> > I had been reviewing them at least every month. However with the
> > recent big patches going in (scalability changes, dynamic
> > reconfig,...) I held off to not impact/delay those patches. I've
> > been super busy at home/work but I'll try to find some time, It
> > would be great if other folks jumped in. They key I've found is to
> > set aside some time and just focus on crunching through. I'd love to
> > see 3.4.6 and 3.5.0 releases soon. We have some good fixes for
> > 3.5.6, and there are only a couple of major 3.5.0 issues to go, if
> > we could get Thawan's "local session" patch and Skye's jetty support
> > in, as well as a few high priority 3.5 fixes (1324 in particular)
> > I'd love to cut a beta release candidate for 3.5.
> >
> > > To split the load, one idea is to set up an hour or two for us to
> > > be
> > simultaneously on irc to discuss the split and any contention on issues.
> > But, if this idea doesn't work, I would be very happy to hear
> alternatives.
> > Ultimately I'm interested in making progress with the patches submitted.
> > >
> >
> > This is a good idea, but I find that just a single person reviewing
> > the patch is often sufficient. Once you boil things down a bit (I typ.
> > find that ~30% of the patches are pretty simple and easy to commit)
> > it's good to have a couple folks focus on the tougher/remaining
> > issues. Esp if it involves a "feature" level change.
> >
> > > If you agree with the idea of being on irc, please share some
> > > slots
> that
> > suit you.
> > >
> >
German Blanco 2013-05-10, 15:38