Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1940, FLUME-1957 - Logging Snapshots of Flume Metrics on Shutdown


Copy link to this message
-
Re: Review Request: FLUME-1940, FLUME-1957 - Logging Snapshots of Flume Metrics on Shutdown
Israel Ekpo 2013-04-24, 11:16

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10416/
-----------------------------------------------------------

(Updated April 24, 2013, 11:16 a.m.)
Review request for Flume.
Changes
-------

Attaching changes made based on feedback from code review comments.

I also realized that the original map was not modified and this was why the error was being thrown.

In this new patch the stop and start times are printed directly and the remaining keys are printed as is from the map.
Description
-------

Logging Metrics from the stop() method for the following components: ChannelCounter, ChannelProcessorCounter, SinkCounter, SinkProcessorCounter, SourceCounter
This addresses bugs FLUME-1940 and FLUME-1957.
    https://issues.apache.org/jira/browse/FLUME-1940
    https://issues.apache.org/jira/browse/FLUME-1957
Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java 502fe9e

Diff: https://reviews.apache.org/r/10416/diff/
Testing
-------
Thanks,

Israel Ekpo