Sqoop, mail # dev - Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly

Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly

Jarek Cecho 2013-01-06, 17:58

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8848/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've fix methods toJson and fillValues() to work with new schema of configuration objects.
This addresses bug SQOOP-812.
   https://issues.apache.org/jira/browse/SQOOP-812
Diffs
-----

  common/src/main/java/org/apache/sqoop/model/FormUtils.java 585d02e
  common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c80bd45

Diff: https://reviews.apache.org/r/8848/diff/
Testing
-------

I've added new unit test.
Thanks,

Jarek Cecho

Re: Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly

Jarek Cecho 2013-01-23, 00:29

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8848/
-----------------------------------------------------------

(Updated Jan. 23, 2013, 12:29 a.m.)
Review request for Sqoop.
Changes
-------

I've incorporated Cheolsoo's comments.
Description
-------

I've fix methods toJson and fillValues() to work with new schema of configuration objects.
This addresses bug SQOOP-812.
   https://issues.apache.org/jira/browse/SQOOP-812
Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/FormUtils.java 585d02eee14a004df45d6fa77dcde4bd65132088
  common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c80bd45947a364e9002db0e7ff0a2603ba75263d

Diff: https://reviews.apache.org/r/8848/diff/
Testing
-------

I've added new unit test.
Thanks,

Jarek Cecho

Re: Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly

Cheolsoo Park 2013-01-23, 00:35

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8848/#review15600
-----------------------------------------------------------

Ship it!
- Cheolsoo Park
On Jan. 23, 2013, 12:29 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8848/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 12:29 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've fix methods toJson and fillValues() to work with new schema of configuration objects.
>
>
> This addresses bug SQOOP-812.
> https://issues.apache.org/jira/browse/SQOOP-812
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/FormUtils.java 585d02eee14a004df45d6fa77dcde4bd65132088
> common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c80bd45947a364e9002db0e7ff0a2603ba75263d
>
> Diff: https://reviews.apache.org/r/8848/diff/
>
>
> Testing
> -------
>
> I've added new unit test.
>
>
> Thanks,
>
> Jarek Cecho
>
>

Re: Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly

Cheolsoo Park 2013-01-22, 23:51

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8848/#review15591
-----------------------------------------------------------
Is it possible to add tests for enum type? It looks like the current test doesn't cover enum type.
common/src/main/java/org/apache/sqoop/model/FormUtils.java
<https://reviews.apache.org/r/8848/#comment33680>

Why can't we just do "(Integer)jsonInputs.get(inputName)"? Does this introduce loss of precision?

common/src/main/java/org/apache/sqoop/model/FormUtils.java
<https://reviews.apache.org/r/8848/#comment33675>

Shouldn't this be "type.isEnum()"?
- Cheolsoo Park
On Jan. 6, 2013, 5:58 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8848/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2013, 5:58 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've fix methods toJson and fillValues() to work with new schema of configuration objects.
>
>
> This addresses bug SQOOP-812.
> https://issues.apache.org/jira/browse/SQOOP-812
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/FormUtils.java 585d02e
> common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c80bd45
>
> Diff: https://reviews.apache.org/r/8848/diff/
>
>
> Testing
> -------
>
> I've added new unit test.
>
>
> Thanks,
>
> Jarek Cecho
>
>

Re: Review Request: SQOOP-812 Sqoop2: Serialization of Configuration objects to and from json is not working properly

Jarek Cecho 2013-01-23, 00:29

> On Jan. 22, 2013, 11:51 p.m., Cheolsoo Park wrote:
> > Is it possible to add tests for enum type? It looks like the current test doesn't cover enum type.

Good catch, I'll add test with Enumeration.
> On Jan. 22, 2013, 11:51 p.m., Cheolsoo Park wrote:
> > common/src/main/java/org/apache/sqoop/model/FormUtils.java, line 440
> > <https://reviews.apache.org/r/8848/diff/1/?file=245275#file245275line440>
> >
> > Shouldn't this be "type.isEnum()"?

Excellent catch, thank you!
> On Jan. 22, 2013, 11:51 p.m., Cheolsoo Park wrote:
> > common/src/main/java/org/apache/sqoop/model/FormUtils.java, line 439
> > <https://reviews.apache.org/r/8848/diff/1/?file=245275#file245275line439>
> >
> > Why can't we just do "(Integer)jsonInputs.get(inputName)"? Does this introduce loss of precision?

Changing this as proposed will lead to following exception being thrown:

java.lang.ClassCastException: java.lang.Long cannot be cast to java.lang.Integer

The issue is that underlying JSON library serializes ints as long objects and thus we need to retype them accordingly.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8848/#review15591
-----------------------------------------------------------
On Jan. 23, 2013, 12:29 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8848/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 12:29 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've fix methods toJson and fillValues() to work with new schema of configuration objects.
>
>
> This addresses bug SQOOP-812.
> https://issues.apache.org/jira/browse/SQOOP-812
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/FormUtils.java 585d02eee14a004df45d6fa77dcde4bd65132088
> common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c80bd45947a364e9002db0e7ff0a2603ba75263d
>
> Diff: https://reviews.apache.org/r/8848/diff/
>
>
> Testing
> -------
>
> I've added new unit test.
>
>
> Thanks,
>
> Jarek Cecho
>
>