Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive, mail # dev - Review Request 14130: Merge vectorization branch to trunk


+
Jitendra Pandey 2013-09-13, 17:52
+
Carl Steinbach 2013-09-16, 00:10
+
Jitendra Pandey 2013-09-18, 20:53
Copy link to this message
-
Re: Review Request 14130: Merge vectorization branch to trunk
Carl Steinbach 2013-09-16, 00:02

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14130/#review26119
-----------------------------------------------------------

.gitignore
<https://reviews.apache.org/r/14130/#comment50977>

    I think we should follow established convention of checking these file instead of generating them since it serves as a useful canary for catching accidental changes to the ORC format.

common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/14130/#comment50978>

    Please add this to hive-default.xml.template along with a description.

metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
<https://reviews.apache.org/r/14130/#comment50979>

    Necessary?

ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt
<https://reviews.apache.org/r/14130/#comment50980>

    We currently use Apache Velocity to generate test code at compile-time (e.g. TestCliDriver, ...). I realize that the templating code in CodeGen and TestCodeGen is pretty simple, but was wondering if it might be better from a build and maintenance standpoint to use Velocity instead.
    
    Also, is it possible to select a less generic file suffix for the template files, e.g. *.t or *.tmpl?

ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt
<https://reviews.apache.org/r/14130/#comment50981>

    In addition to the name (and preferably path) of the template I think this comment should also include the name and path of the code generator, and a warning that it should not be modified by hand.

ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/gen/TestCodeGen.java
<https://reviews.apache.org/r/14130/#comment50982>

    Maybe this should go in ql/src/test/gen. Thoughts?

ql/src/test/queries/clientpositive/vectorization_0.q
<https://reviews.apache.org/r/14130/#comment50984>

    There are a lot of magic numbers in these these new test files. Do they have any special meaning or are they effectively random?

ql/src/test/queries/clientpositive/vectorization_0.q
<https://reviews.apache.org/r/14130/#comment50983>

    What is the expected behavior when vectorized.execution=enabled and the source table is not reading ORC formatted data? I think it's worth adding some additional tests (either positive or negative) to lock down this behavior.
- Carl Steinbach
On Sept. 13, 2013, 5:51 p.m., Jitendra Pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14130/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 5:51 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-5283
>     https://issues.apache.org/jira/browse/HIVE-5283
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Merge vectorization branch to trunk.
>
>
> Diffs
> -----
>
>   .gitignore c0e9b3c
>   build-common.xml ee219a9
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c5a8ff3
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 15a2a81
>   ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalar.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/ColumnCompareScalar.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryMinus.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/FilterColumnCompareColumn.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/FilterColumnCompareScalar.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/FilterScalarCompareColumn.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/FilterStringColumnCompareColumn.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/FilterStringColumnCompareScalar.txt PRE-CREATION
+
Jitendra Pandey 2013-09-18, 20:52
+
Carl Steinbach 2013-09-19, 05:02
+
Jitendra Pandey 2013-09-25, 00:08
+
Jitendra Pandey 2013-09-25, 00:08