Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-529: Enforce usage of --driver and --connection-manager parameters


Copy link to this message
-
Re: Review Request: SQOOP-529: Enforce usage of --driver and --connection-manager parameters
Abhijeet Gaikwad 2012-08-01, 18:37

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6250/#review9696
-----------------------------------------------------------

Ship it!
Last two comments on the Logs, if possible please incorporate them. No need of uploading new diff, I am good with the functionality changes.
"ant test -Dhadoopversion=100" ran a success for me.

Thanks for the patch.
/src/java/org/apache/sqoop/ConnFactory.java
<https://reviews.apache.org/r/6250/#comment20668>

    Change "found" to "find" in the log message.

/src/java/org/apache/sqoop/ConnFactory.java
<https://reviews.apache.org/r/6250/#comment20669>

    change "supports" to "support" in the Log message.
- Abhijeet Gaikwad
On Aug. 1, 2012, 4:03 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6250/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2012, 4:03 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've refactored the code in the way I've designed in the JIRA.
>
>
> This addresses bug SQOOP-529.
>     https://issues.apache.org/jira/browse/SQOOP-529
>
>
> Diffs
> -----
>
>   /src/java/org/apache/sqoop/ConnFactory.java 1367605
>   /src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 1367605
>
> Diff: https://reviews.apache.org/r/6250/diff/
>
>
> Testing
> -------
>
> ant tests passes
>
>
> Thanks,
>
> Jarek Cecho
>
>