Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter tests to repo"


Copy link to this message
-
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter tests to repo"
Venkat Ranganathan 2013-05-25, 00:37

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21042
-----------------------------------------------------------

Ship it!
I successfully got it compiled and ran the unit tests to make sure nothing was broken.   Still there are a few places where logger is not properly used.   Many cases of System.out can be factored like that.   Also, constructs like this
   LOG.error("Setup fail with SQLException: " + StringUtils.stringifyException(e));
Can be simply
   LOG.error("Setup failed", e);
Unless there is a specific reason.  
These things can be addressed in a follow on JIRA I feel as this changeset is big.

- Venkat Ranganathan
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
>     https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
>   conf/MSTest.properties PRE-CREATION
>   src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
>   src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
>   src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
>   testdata/DatatypeTestData-export-lite.txt PRE-CREATION
>   testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>