-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8063/
-----------------------------------------------------------

Review request for Flume.
Description
-------

Improved thread handling in SqoopOutputFormatLoadExecutor. Removed the synchronized blocks and wait/notify.
This addresses bug SQOOP-690.
    https://issues.apache.org/jira/browse/SQOOP-690
Diffs
-----

  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 0d636ae

Diff: https://reviews.apache.org/r/8063/diff/
Testing
-------

Ran unit tests, and on a real cluster.
Thanks,

Hari Shreedharan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8063/
-----------------------------------------------------------

(Updated Nov. 15, 2012, 1:12 a.m.)
Review request for Flume.
Changes
-------

Making Data's content also volatile
Description
-------

Improved thread handling in SqoopOutputFormatLoadExecutor. Removed the synchronized blocks and wait/notify.
This addresses bug SQOOP-690.
    https://issues.apache.org/jira/browse/SQOOP-690
Diffs (updated)
-----

  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java f6fff0b
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 0d636ae

Diff: https://reviews.apache.org/r/8063/diff/
Testing
-------

Ran unit tests, and on a real cluster.
Thanks,

Hari Shreedharan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8063/#review13456
-----------------------------------------------------------
Hi Hari, you just posted a sqoop issue to the flume group to review? Was this your intention... I had a glance at the original issue but it didn't look related to flume?

- Juhani Connolly
On Nov. 15, 2012, 1:12 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8063/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2012, 1:12 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Improved thread handling in SqoopOutputFormatLoadExecutor. Removed the synchronized blocks and wait/notify.
>
>
> This addresses bug SQOOP-690.
>     https://issues.apache.org/jira/browse/SQOOP-690
>
>
> Diffs
> -----
>
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java f6fff0b
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 0d636ae
>
> Diff: https://reviews.apache.org/r/8063/diff/
>
>
> Testing
> -------
>
> Ran unit tests, and on a real cluster.
>
>
> Thanks,
>
> Hari Shreedharan
>
>

> On Nov. 15, 2012, 1:53 a.m., Juhani Connolly wrote:
> > Hi Hari, you just posted a sqoop issue to the flume group to review? Was this your intention... I had a glance at the original issue but it didn't look related to flume?

Sorry, old habits die hard! ;)

It was not intended for Flume, but for Sqoop!

Sorry for the spam!
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8063/#review13456
-----------------------------------------------------------
On Nov. 15, 2012, 1:12 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8063/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2012, 1:12 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Improved thread handling in SqoopOutputFormatLoadExecutor. Removed the synchronized blocks and wait/notify.
>
>
> This addresses bug SQOOP-690.
>     https://issues.apache.org/jira/browse/SQOOP-690
>
>
> Diffs
> -----
>
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java f6fff0b
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 0d636ae
>
> Diff: https://reviews.apache.org/r/8063/diff/
>
>
> Testing
> -------
>
> Ran unit tests, and on a real cluster.
>
>
> Thanks,
>
> Hari Shreedharan
>
>