Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: Fix for SQOOP-937


+
Venkat Ranganathan 2013-03-13, 19:18
+
Jarek Cecho 2013-03-15, 04:38
+
Venkat Ranganathan 2013-03-15, 04:46
+
Venkat Ranganathan 2013-03-19, 21:25
+
Jarek Cecho 2013-03-20, 21:30
+
Venkat Ranganathan 2013-03-19, 16:45
+
Venkat Ranganathan 2013-03-19, 18:06
+
Venkat Ranganathan 2013-03-21, 00:08
+
Jarek Cecho 2013-03-22, 03:22
+
Jarek Cecho 2013-03-22, 03:24
Copy link to this message
-
Re: Review Request: Fix for SQOOP-932
Jarek Cecho 2013-03-20, 21:16

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10018/#review18174
-----------------------------------------------------------
Hi Venkat,
good job on this patch. I do have one question:
src/java/org/apache/sqoop/manager/DirectNetezzaManager.java
<https://reviews.apache.org/r/10018/#comment38344>

    My Netezza knowledge is a bit rusty these day, but I do have feeling that the external table parameter "NULLVALUE" is used only for string based columns (varchar, ...). For all other column types (int, float, ...) empty string is used to encode NULL value. On precondition that this is still the case, shouldn't the condition be more if(nullNonStrValue != null) { error; }?
Jarcec

- Jarek Cecho
On March 19, 2013, 6:06 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10018/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 6:06 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Fixes for SQOOP-932
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/lib/DelimiterSet.java ef62ba0
>   src/java/org/apache/sqoop/manager/DirectNetezzaManager.java 0a1e605
>   src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableExportMapper.java 410a569
>   src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java 9e6cab6
>   src/java/org/apache/sqoop/mapreduce/netezza/NetezzaExternalTableExportJob.java 2a702d9
>   src/java/org/apache/sqoop/mapreduce/netezza/NetezzaExternalTableImportJob.java 7ee6f70
>   src/test/com/cloudera/sqoop/manager/DirectNetezzaExportManualTest.java 938ffc5
>   src/test/com/cloudera/sqoop/manager/NetezzaExportManualTest.java 50d27fe
>   src/test/com/cloudera/sqoop/manager/NetezzaImportManualTest.java 3482dd8
>
> Diff: https://reviews.apache.org/r/10018/diff/
>
>
> Testing
> -------
>
> All unit tests pass - added more tests for testing this functionality
>
>
> Thanks,
>
> Venkat Ranganathan
>
>

+
Venkat Ranganathan 2013-03-21, 03:41
+
Jarek Cecho 2013-03-21, 02:17
+
Venkat Ranganathan 2013-03-21, 01:38
+
Jarek Cecho 2013-03-21, 00:41
+
Venkat Ranganathan 2013-03-20, 23:48
+
Venkat Ranganathan 2013-03-20, 23:43
+
Jarek Cecho 2013-03-22, 03:21
+
Venkat Ranganathan 2013-03-21, 18:14
+
Venkat Ranganathan 2013-03-22, 03:29
+
Venkat Ranganathan 2013-03-21, 04:34
+
Venkat Ranganathan 2013-03-21, 04:34
+
Venkat Ranganathan 2013-03-22, 03:40
+
Jarek Cecho 2013-03-22, 03:52
+
Venkat Ranganathan 2013-04-15, 14:46
+
Venkat Ranganathan 2013-04-15, 14:57
+
Jarek Cecho 2013-04-15, 17:09
+
Venkat Ranganathan 2013-04-16, 14:47
+
Jarek Cecho 2013-04-16, 16:57
+
Raghav Gautam 2013-05-29, 17:19