Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request 15239: FLUME-2233. MemoryChannel lock contention on every put due to bytesRemaining Semaphore


+
Hari Shreedharan 2013-11-05, 05:43
+
Hari Shreedharan 2013-11-05, 19:42
Copy link to this message
-
Re: Review Request 15239: FLUME-2233. MemoryChannel lock contention on every put due to bytesRemaining Semaphore

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15239/#review28209
-----------------------------------------------------------
Hari, were you able to take any measurements on how much perf improvement this change made ?
flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/15239/#comment54887>

    Better to state 'byteCapacity limit is not enforced' instead of  'memoryLimits are not imposed'.
- Roshan Naik
On Nov. 5, 2013, 7:42 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15239/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 7:42 p.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2233
>     https://issues.apache.org/jira/browse/FLUME-2233
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Added a fix for this issue using an additional parameter, which can be used to disable memory checks.
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 688323d
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 3a3038c
>
> Diff: https://reviews.apache.org/r/15239/diff/
>
>
> Testing
> -------
>
> All current tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>

+
Hari Shreedharan 2013-11-05, 20:05
+
Hari Shreedharan 2013-11-05, 20:06
+
Hari Shreedharan 2013-11-07, 05:53
+
Roshan Naik 2013-11-07, 19:39