Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-820 Escape table name in export job only if it's required by connector


Copy link to this message
-
Review Request: SQOOP-820 Escape table name in export job only if it's required by connector
Jarek Cecho 2013-01-08, 15:18

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8891/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've added new method to ConnManager that will return boolean value to see if Sqoop common code should automatically escape table  on export. This method returns false by default.
This addresses bug SQOOP-820.
    https://issues.apache.org/jira/browse/SQOOP-820
Diffs
-----

  src/java/org/apache/sqoop/manager/ConnManager.java 21eea93
  src/java/org/apache/sqoop/manager/PostgresqlManager.java 7e6284e
  src/java/org/apache/sqoop/manager/SQLServerManager.java 0c39599
  src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java 7c52110

Diff: https://reviews.apache.org/r/8891/diff/
Testing
-------

* Unit tests seems to be passing
* I've verified using PostgreSQL and Microsoft SQL Server third party tests that this change will not break custom schema support introduced in SQOOP-601 and SQOOP-540.
Thanks,

Jarek Cecho